ci: Stop running iOSSwift tests on simulator #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We run the iOSSwift tests on SauceLabs and also with the address sanitizer. Therefore, we can remove running them on a simulator without address sanitizer.
philipphofmann
requested review from
brustolin and
armcknight
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3446 +/- ##
=============================================
+ Coverage 88.952% 88.957% +0.004%
=============================================
Files 525 525
Lines 56591 56598 +7
Branches 20369 20374 +5
=============================================
+ Hits 50339 50348 +9
+ Misses 5330 5329 -1
+ Partials 922 921 -1 see 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
brustolin
approved these changes
Nov 27, 2023
armcknight
pushed a commit
that referenced
this pull request
Nov 28, 2023
We run the iOSSwift tests on SauceLabs and also with the address sanitizer. Therefore, we can remove running them on a simulator without address sanitizer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run the iOSSwift tests on SauceLabs and also with the address sanitizer. Therefore, we can remove running them on a simulator without address sanitizer.
#skip-changelog