Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove "experimental" warning from SentryTracedView #3441

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

brustolin
Copy link
Contributor

GA SwiftUI support

close #2572

#skip-changelog

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #3441 (a220311) into main (b064665) will decrease coverage by 0.043%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3441       +/-   ##
=============================================
- Coverage   89.019%   88.977%   -0.043%     
=============================================
  Files          525       525               
  Lines        56590     56428      -162     
  Branches     20365     20072      -293     
=============================================
- Hits         50376     50208      -168     
+ Misses        5298      5297        -1     
- Partials       916       923        +7     

see 77 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b064665...a220311. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1257.65 ms 1268.44 ms 10.79 ms
Size 22.85 KiB 413.41 KiB 390.56 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ecd9ecd 1191.76 ms 1216.92 ms 25.16 ms
14a1101 1242.71 ms 1272.02 ms 29.31 ms
608755c 1220.23 ms 1239.76 ms 19.52 ms
9e6665f 1233.33 ms 1257.14 ms 23.81 ms
881a955 1209.47 ms 1225.94 ms 16.47 ms
760d953 1226.81 ms 1230.22 ms 3.41 ms
94b89eb 1236.08 ms 1264.58 ms 28.50 ms
32e64d1 1224.45 ms 1238.94 ms 14.49 ms
2cf1b84 1221.10 ms 1230.34 ms 9.24 ms
9acdca2 1242.45 ms 1249.63 ms 7.18 ms

App size

Revision Plain With Sentry Diff
ecd9ecd 20.76 KiB 420.23 KiB 399.47 KiB
14a1101 20.76 KiB 436.25 KiB 415.49 KiB
608755c 20.76 KiB 436.33 KiB 415.57 KiB
9e6665f 22.84 KiB 403.52 KiB 380.67 KiB
881a955 22.85 KiB 407.63 KiB 384.78 KiB
760d953 20.76 KiB 434.94 KiB 414.18 KiB
94b89eb 20.76 KiB 399.20 KiB 378.43 KiB
32e64d1 20.76 KiB 433.18 KiB 412.42 KiB
2cf1b84 20.76 KiB 431.91 KiB 411.15 KiB
9acdca2 22.84 KiB 401.44 KiB 378.59 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a Changelog entry and wait until 8.16.1 is released before merging this.

@brustolin brustolin merged commit 02a972c into main Nov 23, 2023
68 of 71 checks passed
@brustolin brustolin deleted the chore/ga-swiftui-support branch November 23, 2023 11:42
armcknight pushed a commit that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SwiftUI APM GA
2 participants