-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove relative component of import #3332
Conversation
@vaind Would you mind reviewing this one? I'm not sure why the import was originally written that way. Is this going to break the Dart SDK somehow? |
Codecov Report
@@ Coverage Diff @@
## main #3332 +/- ##
=============================================
- Coverage 89.271% 89.213% -0.059%
=============================================
Files 501 501
Lines 54222 54217 -5
Branches 19481 19481
=============================================
- Hits 48405 48369 -36
- Misses 4962 4986 +24
- Partials 855 862 +7 see 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5e66a38 | 1209.10 ms | 1233.90 ms | 24.79 ms |
cd39d58 | 1203.87 ms | 1239.88 ms | 36.01 ms |
f8fc36d | 1226.31 ms | 1247.80 ms | 21.49 ms |
102f2a6 | 1225.71 ms | 1244.28 ms | 18.57 ms |
db31083 | 1227.69 ms | 1243.56 ms | 15.87 ms |
7419285 | 1209.53 ms | 1244.72 ms | 35.19 ms |
c6773e5 | 1222.48 ms | 1240.02 ms | 17.54 ms |
443723a | 1205.24 ms | 1220.52 ms | 15.28 ms |
a2af9fa | 1236.29 ms | 1251.67 ms | 15.38 ms |
8f397a7 | 1219.12 ms | 1236.67 ms | 17.55 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5e66a38 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
cd39d58 | 20.76 KiB | 435.26 KiB | 414.50 KiB |
f8fc36d | 20.76 KiB | 419.70 KiB | 398.94 KiB |
102f2a6 | 20.76 KiB | 433.18 KiB | 412.42 KiB |
db31083 | 22.85 KiB | 407.63 KiB | 384.78 KiB |
7419285 | 20.76 KiB | 432.99 KiB | 412.22 KiB |
c6773e5 | 20.76 KiB | 435.25 KiB | 414.49 KiB |
443723a | 20.76 KiB | 414.44 KiB | 393.68 KiB |
a2af9fa | 20.76 KiB | 432.88 KiB | 412.11 KiB |
8f397a7 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vaind Would you mind reviewing this one? I'm not sure why the import was originally written that way. Is this going to break the Dart SDK somehow?
I don't think there was any specific reason for this - just using the actual path to the import file. Maybe it was even added automatically 🤷
Also, I don't think this would have any impact on Dart because this is an internal file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for confirming @vaind and for suggesting the original change @jboulter11! |
Thank you very much for getting this taken care of for me. 😄 |
Co-authored-by: Jim Boulter <[email protected]>
Reported with a proposed fix in #3331, but that can't run all the necessary CI checks
#skip-changelog