Skip to content

ci: only archive derived data logs if the build step fails #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
armcknight merged 2 commits into from
May 9, 2023
Merged

ci: only archive derived data logs if the build step fails #3011

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b94912
ci: only archive derived data logs if the build step fails
armcknight May 8, 2023
b8acfc4
put back in original location
armcknight May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ jobs:

# We split building and running tests in two steps so we know how long running the tests takes.
- name: Build tests
id: build_tests
run: ./scripts/xcode-test.sh ${{matrix.platform}} ${{matrix.test-destination-os}} $GITHUB_REF_NAME ci build-for-testing

- name: Run tests
Expand All @@ -209,7 +210,7 @@ jobs:

- name: Archiving DerivedData Logs
uses: actions/upload-artifact@v3
if: failure()
if: steps.build_tests.outcome == 'failure'
with:
name: derived-data-${{matrix.platform}}-xcode-${{matrix.xcode}}-os-${{matrix.test-destination-os}}
path: |
Expand Down