Skip to content

fix: testNoBreadcrumbForTextFieldEditingChanged flakiness #2992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brustolin merged 8 commits into from
May 4, 2023
Merged

fix: testNoBreadcrumbForTextFieldEditingChanged flakiness #2992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4f0963e
Update UIEventBreadcrumbTests.swift
brustolin May 3, 2023
4c79dd3
Update UIEventBreadcrumbTests.swift
brustolin May 3, 2023
92515d3
Update UIEventBreadcrumbTests.swift
brustolin May 3, 2023
6f1e193
Merge branch 'main' into feat/fix-uitest
brustolin May 3, 2023
1781aff
Update UIEventBreadcrumbTests.swift
brustolin May 3, 2023
b9cc90b
Update test.yml
brustolin May 3, 2023
c2c0fa7
Update test.yml
brustolin May 3, 2023
209fced
Update test.yml
brustolin May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,14 +281,14 @@ jobs:

ui-tests:
name: UI Tests for ${{matrix.target}} on Simulators
runs-on: macos-12
strategy:
runs-on: macos-13
strategy:
matrix:
target: ['ios_swift', 'ios_objc', 'tvos_swift']

steps:
- uses: actions/checkout@v3
- run: ./scripts/ci-select-xcode.sh
- run: ./scripts/ci-select-xcode.sh "14.3"

# GitHub Actions sometimes fail to launch the UI tests. Therefore we retry
- name: Run Fastlane
Expand Down
9 changes: 4 additions & 5 deletions Samples/iOS-Swift/iOS-SwiftUITests/UIEventBreadcrumbTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,16 @@ class UIEventBreadcrumbTests: XCTestCase {
app.buttons["Extra"].tap()
app.buttons["UI event tests"].tap()

let label = app.staticTexts["breadcrumbLabel"]

//Trigger a change in textfield
app.buttons["editingChangedButton"].tap()
app.buttons["editingChangedButton"].afterWaitingForExistence("Did not find editingChangedButton").tap()

//Check the last breadcrumb is the button being pressed
XCTAssertEqual(label.label, "performEditingChangedPressed:")
app.staticTexts["performEditingChangedPressed:"].waitForExistence("performEditingChangedPressed: not called")

//Trigger an endEditing in textfield
app.buttons["editingDidEndButton"].tap()
//Check the last breadcrumb is the endEditing from the textfield and not the button being pressed
XCTAssertEqual(label.label, "textFieldEndChanging:")
app.staticTexts["textFieldEndChanging:"].waitForExistence("textFieldEndChanging: not called")
}

func waitForExistenceOfMainScreen() {
Expand Down