perf: gather profiler metrics gathering on a low-pri queue #2956
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import Foundation | ||
| import Sentry | ||
|
|
||
| public class TestDispatchFactory: SentryDispatchFactory { | ||
| public var vendedSourceHandler: ((TestDispatchSourceWrapper) -> Void)? | ||
| public var vendedQueueHandler: ((TestSentryDispatchQueueWrapper) -> Void)? | ||
|
|
||
| public override func queue(withName name: UnsafePointer<CChar>, attributes: __OS_dispatch_queue_attr) -> SentryDispatchQueueWrapper { | ||
| let queue = TestSentryDispatchQueueWrapper(name: name, attributes: attributes) | ||
| vendedQueueHandler?(queue) | ||
| return queue | ||
| } | ||
|
|
||
| public override func source(withInterval interval: UInt64, leeway: UInt64, queue queueWrapper: SentryDispatchQueueWrapper, eventHandler: @escaping () -> Void) -> SentryDispatchSourceWrapper { | ||
| let source = TestDispatchSourceWrapper(eventHandler: eventHandler) | ||
| vendedSourceHandler?(source) | ||
| return source | ||
| } | ||
|
|
||
| public override func source(withInterval interval: UInt64, leeway: UInt64, queueName: UnsafePointer<CChar>, attributes: __OS_dispatch_queue_attr, eventHandler: @escaping () -> Void) -> SentryDispatchSourceWrapper { | ||
| let source = TestDispatchSourceWrapper(eventHandler: eventHandler) | ||
| vendedSourceHandler?(source) | ||
| return source | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import Foundation | ||
| import Sentry | ||
|
|
||
| public class TestDispatchSourceWrapper: SentryDispatchSourceWrapper { | ||
| public struct Override { | ||
| public var eventHandler: (() -> Void)? | ||
| } | ||
| public var overrides = Override() | ||
|
|
||
| public init(eventHandler: @escaping () -> Void) { | ||
| self.overrides.eventHandler = eventHandler | ||
| super.init() | ||
| } | ||
|
|
||
| public override func cancel() { | ||
| // no-op | ||
| } | ||
|
|
||
| public func fire() { | ||
| self.overrides.eventHandler?() | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| #import <Foundation/Foundation.h> | ||
|
|
||
| @class SentryDispatchQueueWrapper; | ||
| @class SentryDispatchSourceWrapper; | ||
|
|
||
| NS_ASSUME_NONNULL_BEGIN | ||
|
|
||
| /** | ||
| * A type of object that vends wrappers for dispatch queues and sources, which can be subclassed to | ||
| * vend their mocked test subclasses. | ||
| */ | ||
| @interface SentryDispatchFactory : NSObject | ||
|
|
||
| /** | ||
| * Generate a new @c SentryDispatchQueueWrapper . | ||
| */ | ||
| - (SentryDispatchQueueWrapper *)queueWithName:(const char *)name | ||
| attributes:(dispatch_queue_attr_t)attributes; | ||
|
|
||
| /** | ||
| * Generate a @c dispatch_source_t using the provided @c SentryDispatchQueueWrapper . | ||
| */ | ||
| - (SentryDispatchSourceWrapper *)sourceWithInterval:(uint64_t)interval | ||
| leeway:(uint64_t)leeway | ||
| queue:(SentryDispatchQueueWrapper *)queueWrapper | ||
| eventHandler:(void (^)(void))eventHandler; | ||
|
|
||
| /** | ||
| * Generate a @c dispatch_source_t by internally vending the required @c SentryDispatchQueueWrapper | ||
| * . | ||
| */ | ||
| - (SentryDispatchSourceWrapper *)sourceWithInterval:(uint64_t)interval | ||
| leeway:(uint64_t)leeway | ||
| queueName:(const char *)queueName | ||
| attributes:(dispatch_queue_attr_t)attributes | ||
| eventHandler:(void (^)(void))eventHandler; | ||
|
|
||
| @end | ||
|
|
||
| NS_ASSUME_NONNULL_END |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| #import "SentryDispatchFactory.h" | ||
| #import "SentryDispatchQueueWrapper.h" | ||
| #import "SentryDispatchSourceWrapper.h" | ||
|
|
||
| @implementation SentryDispatchFactory | ||
|
|
||
| - (SentryDispatchQueueWrapper *)queueWithName:(const char *)name | ||
| attributes:(dispatch_queue_attr_t)attributes | ||
| { | ||
| return [[SentryDispatchQueueWrapper alloc] initWithName:name attributes:attributes]; | ||
| } | ||
|
|
||
| - (SentryDispatchSourceWrapper *)sourceWithInterval:(uint64_t)interval | ||
| leeway:(uint64_t)leeway | ||
| queue:(SentryDispatchQueueWrapper *)queueWrapper | ||
| eventHandler:(void (^)(void))eventHandler | ||
| { | ||
| return [[SentryDispatchSourceWrapper alloc] initTimerWithInterval:interval | ||
| leeway:leeway | ||
| queue:queueWrapper | ||
| eventHandler:eventHandler]; | ||
| } | ||
|
|
||
| - (SentryDispatchSourceWrapper *)sourceWithInterval:(uint64_t)interval | ||
| leeway:(uint64_t)leeway | ||
| queueName:(const char *)queueName | ||
| attributes:(dispatch_queue_attr_t)attributes | ||
| eventHandler:(void (^)(void))eventHandler | ||
| { | ||
| return [self sourceWithInterval:interval | ||
| leeway:leeway | ||
| queue:[self queueWithName:queueName attributes:attributes] | ||
| eventHandler:eventHandler]; | ||
| } | ||
|
|
||
| @end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,13 +3,7 @@ | |
|
|
||
| NS_ASSUME_NONNULL_BEGIN | ||
|
|
||
|
Comment on lines
-6
to
-12
Member
Author
There was a problem hiding this comment. This is no longer true since we bumped our min supported version. I believe we can also change this: sentry-cocoa/Sources/Sentry/SentryDispatchQueueWrapper.m Lines 16 to 17 in d257eb9 This is now exposed as a property in the public interface so it can be accessed when setting up a new |
||
| @implementation SentryDispatchQueueWrapper | ||
|
|
||
| - (instancetype)init | ||
| { | ||
|
|
@@ -24,14 +18,14 @@ - (instancetype)init | |
| - (instancetype)initWithName:(const char *)name attributes:(dispatch_queue_attr_t)attributes; | ||
| { | ||
| if (self = [super init]) { | ||
| _queue = dispatch_queue_create(name, attributes); | ||
| } | ||
| return self; | ||
| } | ||
|
|
||
| - (void)dispatchAsyncWithBlock:(void (^)(void))block | ||
| { | ||
| dispatch_async(_queue, ^{ | ||
| @autoreleasepool { | ||
| block(); | ||
| } | ||
|
|
@@ -60,7 +54,7 @@ - (void)dispatchAfter:(NSTimeInterval)interval block:(dispatch_block_t)block | |
| { | ||
| dispatch_time_t delta = (int64_t)(interval * NSEC_PER_SEC); | ||
| dispatch_time_t when = dispatch_time(DISPATCH_TIME_NOW, delta); | ||
| dispatch_after(when, _queue, ^{ | ||
| @autoreleasepool { | ||
| block(); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| #import <Foundation/Foundation.h> | ||
|
|
||
| @class SentryDispatchQueueWrapper; | ||
|
|
||
| NS_ASSUME_NONNULL_BEGIN | ||
|
|
||
| /** | ||
| * A wrapper around a @c dispatch_source_t that can be subclassed for mocking in tests. | ||
| */ | ||
| @interface SentryDispatchSourceWrapper : NSObject | ||
|
|
||
| - (instancetype)initTimerWithInterval:(uint64_t)interval | ||
| leeway:(uint64_t)leeway | ||
| queue:(SentryDispatchQueueWrapper *)queueWrapper | ||
| eventHandler:(void (^)(void))eventHandler; | ||
|
|
||
| - (void)cancel; | ||
|
|
||
| @end | ||
|
|
||
| NS_ASSUME_NONNULL_END |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| #import "SentryDispatchSourceWrapper.h" | ||
| #import "SentryDispatchQueueWrapper.h" | ||
|
|
||
| @implementation SentryDispatchSourceWrapper { | ||
| SentryDispatchQueueWrapper *_queueWrapper; | ||
| dispatch_source_t _source; | ||
| } | ||
|
|
||
| - (instancetype)initTimerWithInterval:(uint64_t)interval | ||
| leeway:(uint64_t)leeway | ||
| queue:(SentryDispatchQueueWrapper *)queueWrapper | ||
| eventHandler:(void (^)(void))eventHandler | ||
| { | ||
| if (!(self = [super init])) { | ||
armcknight marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| return nil; | ||
| } | ||
|
|
||
| _queueWrapper = queueWrapper; | ||
| _source = dispatch_source_create(DISPATCH_SOURCE_TYPE_TIMER, 0, 0, queueWrapper.queue); | ||
| dispatch_source_set_event_handler(_source, eventHandler); | ||
| dispatch_source_set_timer( | ||
| _source, dispatch_time(DISPATCH_TIME_NOW, interval), interval, leeway); | ||
| dispatch_resume(_source); | ||
| return self; | ||
| } | ||
|
|
||
| - (void)cancel | ||
| { | ||
| dispatch_cancel(_source); | ||
| } | ||
|
|
||
| @end | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.