-
-
Notifications
You must be signed in to change notification settings - Fork 372
docs: clean up headerdocs #2829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: clean up headerdocs #2829
Conversation
…l declarations of default values in separate @notes; add @c to sentry and builtin declared symbols in headerdocs; some light editing of typos, whitespace and extra newlines
|
Hmm, I just noticed the Build Documentation feature in Xcode, which |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8f397a7 | 1196.55 ms | 1226.82 ms | 30.27 ms |
| 8f397a7 | 1252.37 ms | 1274.80 ms | 22.43 ms |
| 7bc3c0d | 1212.35 ms | 1228.94 ms | 16.59 ms |
| ce4cfaf | 1203.61 ms | 1218.86 ms | 15.25 ms |
| 06548c0 | 1226.71 ms | 1252.37 ms | 25.66 ms |
| 4259afd | 1222.12 ms | 1249.74 ms | 27.62 ms |
| 7fb7afb | 1235.00 ms | 1256.81 ms | 21.81 ms |
| 369222e | 1232.14 ms | 1258.90 ms | 26.76 ms |
| c9724f9 | 1199.38 ms | 1229.54 ms | 30.16 ms |
| 28333b6 | 1247.29 ms | 1262.51 ms | 15.22 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8f397a7 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
| 8f397a7 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
| 7bc3c0d | 20.76 KiB | 427.35 KiB | 406.59 KiB |
| ce4cfaf | 20.76 KiB | 423.19 KiB | 402.43 KiB |
| 06548c0 | 20.76 KiB | 427.36 KiB | 406.59 KiB |
| 4259afd | 20.76 KiB | 419.70 KiB | 398.94 KiB |
| 7fb7afb | 20.76 KiB | 419.69 KiB | 398.94 KiB |
| 369222e | 20.76 KiB | 419.67 KiB | 398.91 KiB |
| c9724f9 | 20.76 KiB | 427.66 KiB | 406.90 KiB |
| 28333b6 | 20.76 KiB | 424.69 KiB | 403.93 KiB |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2829 +/- ##
==========================================
+ Coverage 81.30% 81.33% +0.03%
==========================================
Files 258 258
Lines 24131 24150 +19
Branches 10706 10719 +13
==========================================
+ Hits 19619 19642 +23
+ Misses 4014 4011 -3
+ Partials 498 497 -1
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
We can revisit this once we start publishing code docs. |
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for doing this 👏 💯 🥇
Please merge this quickly to avoid conflicts. LGTM 🌟
|
@philipphofmann This was the first time I encountered the high risk file check, note that I added the new sha to its output to tighten up the round trip in that workflow a bit: https://github.com/getsentry/sentry-cocoa/pull/2829/files#diff-9219d0ee596a5725e4e618eb75d7fb9497df6ad02b984e46b857855d03161922R13 |
After making some of the changes in #2804 , I noticed some other irregularities in nearby headerdocs.
@noteentries@cto sentry and builtin declared symbols in headerdocs and other tokens that are better viewed in monospace,0andOare better because of the slash through the monospace0.@c@returns Foo(example). I'd rather just save that line and vertical space.@cfor monospaced elements in headerdocs. This gives it treatment in the source file and in doc popovers.<code></codedoesn't appear to do anything:#skip-changelog