ref: Make SpanProtocol.data non nullable #2409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Philipp Hofmann <[email protected]>
brustolin
requested review from
armcknight and
philipphofmann
as code owners
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a9e77dc | 1231.94 ms | 1254.85 ms | 22.91 ms |
| 58ec104 | 1244.29 ms | 1269.67 ms | 25.39 ms |
| 9be1db2 | 1219.42 ms | 1245.66 ms | 26.24 ms |
| 88ac2c2 | 1223.04 ms | 1243.12 ms | 20.08 ms |
| d10145a | 1232.65 ms | 1257.55 ms | 24.90 ms |
| 7eee302 | 1228.73 ms | 1241.94 ms | 13.21 ms |
| dcac8ad | 1238.82 ms | 1247.80 ms | 8.98 ms |
| 68094b3 | 1214.14 ms | 1255.09 ms | 40.95 ms |
| e2cec76 | 1189.48 ms | 1229.84 ms | 40.36 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a9e77dc | 20.75 KiB | 379.12 KiB | 358.36 KiB |
| 58ec104 | 20.75 KiB | 379.11 KiB | 358.36 KiB |
| 9be1db2 | 20.75 KiB | 373.94 KiB | 353.19 KiB |
| 88ac2c2 | 20.75 KiB | 373.61 KiB | 352.86 KiB |
| d10145a | 20.75 KiB | 379.12 KiB | 358.36 KiB |
| 7eee302 | 20.75 KiB | 374.73 KiB | 353.97 KiB |
| dcac8ad | 20.75 KiB | 379.11 KiB | 358.36 KiB |
| 68094b3 | 20.75 KiB | 373.94 KiB | 353.19 KiB |
| e2cec76 | 20.75 KiB | 381.81 KiB | 361.06 KiB |
Previous results on branch: ref/spanprotocol-data-nonnull
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 66cba44 | 1248.71 ms | 1261.82 ms | 13.11 ms |
| ee03e12 | 1228.43 ms | 1251.67 ms | 23.24 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 66cba44 | 20.75 KiB | 379.12 KiB | 358.36 KiB |
| ee03e12 | 20.75 KiB | 379.12 KiB | 358.36 KiB |
Member
|
@brustolin, please merge 8.0.0 into this branch. |
philipphofmann
approved these changes
Nov 22, 2022
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
LGTM apart from the Changelog.
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Make SpanProtocol.data non nullable ([#2409](https://github.com/getsentry/sentry-cocoa/pull/2409))If none of the above apply, you can opt out of this check by adding |
kevinrenskers
added a commit
that referenced
this pull request
Nov 22, 2022
* 8.0.0: ref: Fix typos in OOMTracker (#2431) ref: Make SpanProtocol.data non nullable (#2409) ref: add/improve logging (#2420) ref: bump supported OS versions (#2414) test: shorten some tests (#2428) ref: Remove `- [SentryOptions initWithDict:didFailWithError:]` (#2404) ref: Mark [SpanProtocol setExtraValue:forKey] as deprecated (#2413) typos (#2421) test: Disable NSDataTracker in clearTestState (#2418) Update CHANGELOG.md (#2415) feat: Properly demangle Swift class name (#2162) chore: Create 8.0.0 branch test: include Sentry changes in hash keys (#2412) release: 7.31.2 fix: Crash in Client when reading integrations (#2398) test: tooling improvements (#2400) fix: Don't increase session's error count for dropped events (#2374) Update CHANGELOG.md (#2396) release: 7.31.1 Fix: Set the correct OOM event timestamp (#2394) # Conflicts: # Sentry.xcodeproj/project.pbxproj # SentryPrivate.podspec # scripts/add-sentry-to-vlc.patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
SpanProtocol.datais now non nullable.💡 Motivation and Context
close #1257
💚 How did you test it?
📝 Checklist