Skip to content

fix: Fixed flaky testTimezoneChangeNotificationBreadcrumb #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinrenskers merged 2 commits into from
Nov 2, 2022
Merged

fix: Fixed flaky testTimezoneChangeNotificationBreadcrumb #2335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a5b188
fix: Fixed flaky testTimezoneChangeNotificationBreadcrumb
kevinrenskers Oct 27, 2022
4fd9b4a
Bypass NSNotificationCenter for tests
kevinrenskers Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Sentry.xcodeproj/xcshareddata/xcschemes/Sentry.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,6 @@
<Test
Identifier = "SentryStacktraceBuilderTests/testAsyncStacktraces_disabled()">
</Test>
<Test
Identifier = "SentrySystemEventBreadcrumbsTest/testTimezoneChangeNotificationBreadcrumb_disabled()">
</Test>
</SkippedTests>
</TestableReference>
</Testables>
Expand Down
1 change: 1 addition & 0 deletions Sources/Sentry/include/SentrySystemEventBreadcrumbs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ SENTRY_NO_INIT

#if TARGET_OS_IOS
- (void)start:(UIDevice *)currentDevice;
- (void)timezoneEventTriggered;
#endif

- (void)stop;
Expand Down
5 changes: 3 additions & 2 deletions Tests/SentryTests/Integrations/Breadcrumbs/SentrySystemEventBreadcrumbsTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,13 +252,14 @@ class SentrySystemEventBreadcrumbsTest: XCTestCase {
}
}

func testTimezoneChangeNotificationBreadcrumb_disabled() {
func testTimezoneChangeNotificationBreadcrumb() {
let scope = Scope()
sut = fixture.getSut(scope: scope, currentDevice: nil)

fixture.currentDateProvider.timezoneOffsetValue = 7_200

NotificationCenter.default.post(Notification(name: NSNotification.Name.NSSystemTimeZoneDidChange))
sut.timezoneEventTriggered()

assertBreadcrumbAction(scope: scope, action: "TIMEZONE_CHANGE") { data in
XCTAssertEqual(data["previous_seconds_from_gmt"] as? Int, 0)
XCTAssertEqual(data["current_seconds_from_gmt"] as? Int, 7_200)
Expand Down