Skip to content

Conversation

@vaind
Copy link
Contributor

@vaind vaind commented Oct 4, 2022

Used Get-ChildItem . -Filter *.yml | Foreach-Object { pin-github-action --allow 'actions/*,getsentry/*' $_.FullName } and manually reverted the most disturbing formatting changes it's making (line breaks on long lines)...

There should be no need to do this again + new PRs will automatically get a failure through Danger.

#skip-changelog

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vaind.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1266.94 ms 1278.20 ms 11.27 ms
Size 20.51 KiB 333.10 KiB 312.59 KiB

Baseline results on branch: master

Startup times

Revision Plain With Sentry Diff
075911d 1256.73 ms 1271.22 ms 14.49 ms
864c39a 1226.12 ms 1248.26 ms 22.13 ms
9fc2dd0 1246.14 ms 1275.00 ms 28.86 ms
864c39a 1239.45 ms 1256.76 ms 17.31 ms
4a66f00 1259.84 ms 1281.66 ms 21.82 ms
a5ca27b 1231.31 ms 1252.56 ms 21.25 ms
4c1fab4 1222.96 ms 1251.00 ms 28.04 ms
6177f2d 1206.55 ms 1226.20 ms 19.65 ms
e958899 1233.02 ms 1261.86 ms 28.84 ms
0fdf0b2 1194.37 ms 1227.90 ms 33.53 ms

App size

Revision Plain With Sentry Diff
075911d 20.51 KiB 332.90 KiB 312.39 KiB
864c39a 20.51 KiB 335.57 KiB 315.06 KiB
9fc2dd0 20.50 KiB 331.79 KiB 311.28 KiB
864c39a 20.51 KiB 335.57 KiB 315.06 KiB
4a66f00 20.51 KiB 331.79 KiB 311.28 KiB
a5ca27b 20.51 KiB 331.81 KiB 311.31 KiB
4c1fab4 20.51 KiB 331.79 KiB 311.28 KiB
6177f2d 20.51 KiB 332.90 KiB 312.40 KiB
e958899 20.51 KiB 331.92 KiB 311.41 KiB
0fdf0b2 20.51 KiB 332.90 KiB 312.39 KiB

@vaind vaind merged commit c929040 into master Oct 4, 2022
@vaind vaind deleted the ci/pin-actions branch October 4, 2022 12:01
kevinrenskers added a commit that referenced this pull request Oct 4, 2022
* master:
  ci: update and pin GHA to commit hash (#2249)

# Conflicts:
#	.github/workflows/integration-tests.yml
kevinrenskers added a commit that referenced this pull request Oct 4, 2022
* master:
  ci: Fix Validate podspec (#2253)
  fix: Fix VLC integration test (#2251)
  ci: update and pin GHA to commit hash (#2249)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants