Skip to content

Conversation

@philipphofmann
Copy link
Member

📜 Description

Rename db.query to db.sql.query and db.transaction to db.sql.transaction.

💡 Motivation and Context

Aligning span operation names.

💚 How did you test it?

Unit tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

Rename db.query to db.sql.query and db.transaction to
db.sql.transaction.
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1240.41 ms 1252.58 ms 12.17 ms
Size 20.51 KiB 335.52 KiB 315.01 KiB

Baseline results on branch: master

Startup times

Revision Plain With Sentry Diff
5025d2e 1248.52 ms 1251.72 ms 3.20 ms
b869536 1250.37 ms 1274.84 ms 24.47 ms
9fc2dd0 1246.14 ms 1275.00 ms 28.86 ms
e43ce74 1235.77 ms 1252.06 ms 16.29 ms
5025d2e 1245.14 ms 1268.58 ms 23.44 ms
864c39a 1239.45 ms 1256.76 ms 17.31 ms
4a66f00 1259.84 ms 1281.66 ms 21.82 ms
172c95a 1220.08 ms 1251.74 ms 31.66 ms
864c39a 1191.14 ms 1233.38 ms 42.24 ms
4a66f00 1224.73 ms 1241.14 ms 16.41 ms

App size

Revision Plain With Sentry Diff
5025d2e 20.51 KiB 331.79 KiB 311.28 KiB
b869536 20.51 KiB 331.79 KiB 311.28 KiB
9fc2dd0 20.50 KiB 331.79 KiB 311.28 KiB
e43ce74 20.51 KiB 335.49 KiB 314.99 KiB
5025d2e 20.51 KiB 331.79 KiB 311.28 KiB
864c39a 20.51 KiB 335.57 KiB 315.06 KiB
4a66f00 20.51 KiB 331.79 KiB 311.28 KiB
172c95a 20.51 KiB 335.57 KiB 315.06 KiB
864c39a 20.51 KiB 335.57 KiB 315.06 KiB
4a66f00 20.51 KiB 331.79 KiB 311.28 KiB

Previous results on branch: fix/core-data-span-operations

Startup times

Revision Plain With Sentry Diff
a61e652 1261.18 ms 1272.08 ms 10.90 ms

App size

Revision Plain With Sentry Diff
a61e652 20.51 KiB 335.52 KiB 315.01 KiB

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philipphofmann philipphofmann merged commit 074350f into master Sep 26, 2022
@philipphofmann philipphofmann deleted the fix/core-data-span-operations branch September 26, 2022 13:06
kevinrenskers added a commit that referenced this pull request Sep 27, 2022
* master:
  release: 7.26.0
  meta: Fix Changelog concurrent transactions (#2229)
  build(deps): bump fastlane from 2.210.0 to 2.210.1 (#2224)
  Revert "feat: profile concurrent transactions (#2105)" (#2225)
  fix: Align core data span operations (#2222)
  test: Remove empty assert msg for AppStateTests (#2221)
  meta: Fix Changelog (#2219)
  ref: Add typealias for bytes (#2209)
  feat: profile concurrent transactions (#2105)
  ci: Readd cache for UI tests (#2215)

# Conflicts:
#	Sentry.xcodeproj/project.pbxproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants