ci: Remove caching for UI tests #2210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UI tests were using caches that stopped the UI tests from recompiling when there were changes in the library code. Instead, we need to recompile the test sample apps with their UI tests when there are changes in the library code to be able to catch bugs. This is fixed now by removing the cache.
| scheme: "iOS-Swift", | ||
| derived_data_path: "DerivedData", | ||
| skip_archive: true, | ||
| skip_codesigning: true |
Contributor
There was a problem hiding this comment.
This seems to undo the fix from my PR
Contributor
There was a problem hiding this comment.
Oh it was still a draft PR 😅
Member
Author
There was a problem hiding this comment.
Yeah, I'm just playing araound.
Contributor
Performance metrics 🚀
|
This reverts commit 22b13b7.
…remove-cache-for-ui-tests
philipphofmann
requested review from
armcknight,
brustolin and
indragiek
as code owners
Contributor
|
So we can't make automatic signing work at all? :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI tests were using caches that stopped the UI tests from recompiling when there were changes in the library code. Instead, we need to recompile the test sample apps with their UI tests when there are changes in the library code to be able to catch bugs. This is fixed now by removing the cache.
Furthermore, @kevinrenskers opened a PR #2184 to enable automatic code signing for development of the iOS-Swift sample app. CI was green, and we merged it. Without caching we would have caught this error.
#skip-changelog