-
-
Notifications
You must be signed in to change notification settings - Fork 372
feat: Add App Hangs tracking #1861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
@vaind and @marandaneto as they know about ANR on Android and Unity |
vaind
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes below, I'm not confident in my understanding of sentry-cocoa to fully review this.
Co-authored-by: Ivan Dlugos <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1861 +/- ##
==========================================
+ Coverage 91.91% 91.98% +0.06%
==========================================
Files 200 200
Lines 9450 9557 +107
==========================================
+ Hits 8686 8791 +105
- Misses 764 766 +2
Continue to review full report at Codecov.
|
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass, still have plenty of files to review. Thanks for doing this @brustolin.
Co-authored-by: Philipp Hofmann <[email protected]>
AFAIK, for iOS, the app entry point is a But I like this idea better
|
|
Flaky test? |
But only on Catalyst. |
|
@bruno-garcia, made a valid point that we should maybe turn this off by default for now to get some feedback before turning it on by default. We can add it to the list of new features in the wizard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, expect we should disable this per default. When you disable App Hang tracking, we still track them for OOMs to avoid false OOMs right?
Yes. |
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
This reverts commit 2339bee.
📜 Description
When the app stops responding we should create an error event reporting it.
💡 Motivation and Context
Close #1052
💚 How did you test it?
Unit test
📝 Checklist
🔮 Next steps