fix: use correct format specifier for NSInteger (#3164)

getsentry · Jul 29, 2023 · 8919322 · 8919322
1 parent a176fc4
commit 8919322
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/Sources/Sentry/SentryFileManager.m b/Sources/Sentry/SentryFileManager.m
@@ -608,7 +608,7 @@ - (NSNumber *_Nullable)readTimezoneOffset
 
 - (void)storeTimezoneOffset:(NSInteger)offset
 {
-    NSString *timezoneOffsetString = [NSString stringWithFormat:@"%zd", offset];
+    NSString *timezoneOffsetString = [NSString stringWithFormat:@"%ld", (long)offset];
     SENTRY_LOG_DEBUG(@"Persisting timezone offset: %@", timezoneOffsetString);
     @synchronized(self.timezoneOffsetFilePath) {
         if (![self writeData:[timezoneOffsetString dataUsingEncoding:NSUTF8StringEncoding]

diff --git a/Tests/SentryTests/Helper/SentryFileManagerTests.swift b/Tests/SentryTests/Helper/SentryFileManagerTests.swift
@@ -551,6 +551,11 @@ class SentryFileManagerTests: XCTestCase {
         XCTAssertEqual(sut.readTimezoneOffset(), 7_200)
     }
 
+    func testtestStoreAndReadNegativeTimezoneOffset() {
+        sut.storeTimezoneOffset(-1_000)
+        XCTAssertEqual(sut.readTimezoneOffset(), -1_000)
+    }
+
     func testStoreDeleteTimezoneOffset() {
         sut.storeTimezoneOffset(7_200)
         sut.deleteTimezoneOffset()