ref(token): Use secrecy crate to store auth token #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
force-pushed
the
szokeasaurusrex/auth-token-secrecy
branch
from
9c4c9e7
to
f94d50c
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/auth-token-security
branch
from
d594ae1
to
2665d8a
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/auth-token-secrecy
branch
2 times, most recently
from
1b6af57
to
0301966
Compare
The test ensures that when the CLI args are echoed back, anything which might reasonably be an auth token is redacted.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/auth-token-security
branch
from
b55b354
to
35547f7
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/auth-token-secrecy
branch
from
0301966
to
568aacd
Compare
mdtro
approved these changes
Aug 1, 2024
szokeasaurusrex
force-pushed
the
szokeasaurusrex/auth-token-security
branch
from
35547f7
to
3d05326
Compare
Using the secrecy crate prevents the auth token from accidentally being leaked if we log the `AuthToken` struct.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/auth-token-secrecy
branch
from
568aacd
to
28026ee
Compare
|
Very nice, TIL. |
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the secrecy crate prevents the auth token from accidentally being leaked if we log the
AuthTokenstruct.