Skip to content

Improve nginx depends_on policy#3914

Merged
aldy505 merged 2 commits intogetsentry:masterfrom
aminvakil:improve_nginx_depends_on
Sep 2, 2025
Merged

Improve nginx depends_on policy#3914
aldy505 merged 2 commits intogetsentry:masterfrom
aminvakil:improve_nginx_depends_on

Conversation

@aminvakil
Copy link
Collaborator

Fixes #3894.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@aminvakil
Copy link
Collaborator Author

https://docs.docker.com/compose/how-tos/startup-order/

You can test this locally with / without this patch, execute docker compose restart relay and it shall restart nginx afterwards with this patch.

Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aldy505 aldy505 merged commit 85365f1 into getsentry:master Sep 2, 2025
11 of 12 checks passed
@aminvakil aminvakil deleted the improve_nginx_depends_on branch September 3, 2025 05:42
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Nginx keeps using old upstream IP of Relay after Relay restart

3 participants