Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flaky test detector #2874

Closed
wants to merge 25 commits into from
Closed

Conversation

hubertdeng123
Copy link
Member

No description provided.

@hubertdeng123 hubertdeng123 force-pushed the hubertdeng123/flakey-test-detector branch from 313a118 to 17cf0cf Compare March 8, 2024 22:23
@hubertdeng123
Copy link
Member Author

going to put this on hold since it's causing me a lot of pain, going to look into converting the run.sh file to python

@BYK
Copy link
Member

BYK commented Mar 12, 2024

The reason we chose bash was that we could rely on it being available on most of the target systems and without any dependencies.

If we're going to revisit that, may I humbly suggest considering https://xon.sh through a docker image?

That said it may require mounting docker.sock which might be a trouble on certain systems.

@hubertdeng123
Copy link
Member Author

hubertdeng123 commented Mar 12, 2024

Just to clarify, I wasn't planning on rewriting the installer. For integration tests, it doesn't seem like using bash would be a clear advantage given that we're controlling the testing environment and the dependencies that come with it. Are you suggesting xonsh to be used for the installer?

@BYK
Copy link
Member

BYK commented Mar 12, 2024

Oh, right sorry. You may still benefit from using xonsh which is essentially a marriage between Python and bash. But yes, I was thinking about that for the installer.

@hubertdeng123
Copy link
Member Author

Closing this, as #2918 addresses flaky test reporting

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2024
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/flakey-test-detector branch April 22, 2024 17:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants