-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flaky test detector #2874
Add flaky test detector #2874
Conversation
313a118
to
17cf0cf
Compare
going to put this on hold since it's causing me a lot of pain, going to look into converting the |
The reason we chose bash was that we could rely on it being available on most of the target systems and without any dependencies. If we're going to revisit that, may I humbly suggest considering https://xon.sh through a docker image? That said it may require mounting docker.sock which might be a trouble on certain systems. |
Just to clarify, I wasn't planning on rewriting the installer. For integration tests, it doesn't seem like using bash would be a clear advantage given that we're controlling the testing environment and the dependencies that come with it. Are you suggesting xonsh to be used for the installer? |
Oh, right sorry. You may still benefit from using xonsh which is essentially a marriage between Python and bash. But yes, I was thinking about that for the installer. |
Closing this, as #2918 addresses flaky test reporting |
No description provided.