Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update set-up-and-migrate-database.sh #1308

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

drmrbrewer
Copy link
Contributor

It's docker-compose not docker compose

It's `docker-compose` not `docker compose`
@BYK
Copy link
Member

BYK commented Feb 7, 2022

It is docker compose since a while ago 🙂: https://docs.docker.com/compose/cli-command/

@drmrbrewer
Copy link
Contributor Author

@BYK Oh 🤦‍♂️ but I get:

# docker compose run --rm web createuser
unknown flag: --rm
See 'docker --help'.

@BYK
Copy link
Member

BYK commented Feb 7, 2022

@drmrbrewer we do have some version detection code around which then defines a $dc_base here: https://github.com/getsentry/self-hosted/blob/master/install/dc-detect-version.sh

I think you can make this file use $dc_base instead of docker compose directly and that should take case of the issue?

@drmrbrewer
Copy link
Contributor Author

Yep, that should work... done!

@BYK
Copy link
Member

BYK commented Feb 7, 2022

@chadwhitacre nudge

@chadwhitacre chadwhitacre enabled auto-merge (squash) February 7, 2022 21:54
@chadwhitacre
Copy link
Member

Thanks @drmrbrewer @BYK! :)

@chadwhitacre
Copy link
Member

I like this PR so much I approved it twice. 🤩

@chadwhitacre chadwhitacre merged commit f3027d0 into getsentry:master Feb 7, 2022
@drmrbrewer
Copy link
Contributor Author

I am sure this will go down as a significant day in the history of self-hosted sentry. This was the equivalent of laying down a single mosaic tile (or maybe two!) in a luxurious Roman palace. Well, Rome wasn't built in a day, as they say!

@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants