-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reset.sh docker-compose call #1209
Conversation
This has been changed in #1179 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should detect docker-compose version, some users (I won't say few or many as I have no idea) have migrated to docker compose > 2.0.0
and definitely not all of them have symlinked /usr/local/bin/docker-compose
to plugin to make it compatible with this change.
Agreed. It seems like it's time to teach Lines 33 to 36 in 28e413c
|
I don't think of any particular reason not use the whole |
fyi I am not going to do this extra changes, I just fixed the most obvious bug. |
@matti What part of this you disagree with? |
I don't diasagree with anything - I just wont do anything else for this PR, feel free to do as much as you want. |
This comment has been minimized.
This comment has been minimized.
Fine, thanks, I'll take it from here in #1215 . |
No description provided.