Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set worker process to auto #1207

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Set worker process to auto #1207

merged 1 commit into from
Dec 22, 2021

Conversation

aminvakil
Copy link
Collaborator

https://nginx.org/en/docs/ngx_core_module.html#worker_processes:

Defines the number of worker processes.

The optimal value depends on many factors including (but not limited to) the number of CPU cores, the number of hard disk drives that store data, and load pattern. When one is in doubt, setting it to the number of available CPU cores would be a good start (the value “auto” will try to autodetect it).

BYK
BYK approved these changes Dec 18, 2021
View reviewed changes
Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We expect people to front this with a dedicated LB or reverse-proxy but i guess this is harmless so let's give it a shot!

@chadwhitacre
Copy link
Member

Seems reasonable but is there any particular reason to do this now? How did this come up @aminvakil?

@aminvakil
Copy link
Collaborator Author

Seems reasonable but is there any particular reason to do this now? How did this come up @aminvakil?

No, I was just thinking on how to improve nginx.conf and this and #1208 came up for now.

@chadwhitacre
Copy link
Member

Approved. @aminvakil Do you have perms to merge?

@aminvakil
Copy link
Collaborator Author

Approved. @aminvakil Do you have perms to merge?

No, I don't.

@chadwhitacre chadwhitacre merged commit 4ce6fd1 into getsentry:master Dec 22, 2021
@aminvakil aminvakil deleted the nginx_tweaks branch December 22, 2021 16:32
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chadwhitacre chadwhitacre chadwhitacre approved these changes

@BYK BYK BYK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aminvakil @chadwhitacre @BYK