-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs and output tinkering for commit check #1191
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,15 @@ | ||
#!/bin/bash | ||
echo "${_group}Checking for latest commit ... " | ||
|
||
# Checks if we are on latest commit from github if it is running from master branch | ||
if [[ -d "../.git" && "${SKIP_COMMIT_CHECK:-0}" != 1 ]]; then | ||
if [[ $(git branch | sed -n '/\* /s///p') == "master" ]]; then | ||
if [[ $(git rev-parse HEAD) != $(git ls-remote $(git rev-parse --abbrev-ref @{u} | sed 's/\// /g') | cut -f1) ]]; then | ||
echo "Seems like you are not using the latest commit from self-hosted repository. Please pull the latest changes and try again."; | ||
echo "Seems like you are not using the latest commit from the self-hosted repository. Please pull the latest changes and try again, or suppress this check with --skip-commit-check."; | ||
exit 1 | ||
fi | ||
fi | ||
else | ||
echo "skipped" | ||
fi | ||
|
||
echo "${_endgroup}" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,14 +4,20 @@ show_help() { | |
cat <<EOF | ||
Usage: $0 [options] | ||
|
||
Install Sentry with `docker compose`. | ||
Install Sentry with \`docker compose\`. | ||
|
||
Options: | ||
-h, --help Show this message and exit. | ||
--no-user-prompt Skips the initial user creation prompt (ideal for non-interactive installs). | ||
--minimize-downtime EXPERIMENTAL: try to keep accepting events for as long as possible while upgrading. | ||
This will disable cleanup on error, and might leave your installation in partially upgraded state. | ||
This option might not reload all configuration, and is only meant for in-place upgrades. | ||
--minimize-downtime EXPERIMENTAL: try to keep accepting events for as long | ||
as possible while upgrading. This will disable cleanup | ||
on error, and might leave your installation in a | ||
partially upgraded state. This option might not reload | ||
all configuration, and is only meant for in-place | ||
upgrades. | ||
--skip-commit-check Skip the check for the latest commit when on the master | ||
branch of a \`self-hosted\` Git working copy. | ||
--skip-user-prompt Skip the initial user creation prompt (ideal for non- | ||
interactive installs). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Opportunistic reformat for 80-char lines, sort alphabetically. |
||
EOF | ||
} | ||
|
||
|
@@ -22,7 +28,8 @@ SKIP_COMMIT_CHECK="${SKIP_COMMIT_CHECK:-}" | |
while (( $# )); do | ||
case "$1" in | ||
-h | --help) show_help; exit;; | ||
--no-user-prompt) SKIP_USER_PROMPT=1;; | ||
--no-user-prompt) SKIP_USER_PROMPT=1;; # deprecated | ||
--skip-user-prompt) SKIP_USER_PROMPT=1;; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We shouldn't have |
||
--minimize-downtime) MINIMIZE_DOWNTIME=1;; | ||
--skip-commit-check) SKIP_COMMIT_CHECK=1;; | ||
--) ;; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Backticks spawn a subshell here, need to escape them. Regression in #1179.