-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename onpremise to self-hosted #796
Comments
I'm not sure if the effort is worth the benefits. |
GitHub handles renames gracefully. The one lingering question I've had is forks, but it seems from testing (not seeing docs) that there's no issue with a fork of a renamed repo. The fork keeps the old name, and its connection to the renamed parent. If anyone with a fork has the upstream set as a remote, GitHub redirection/aliasing ensures that they are unaffected—as long as we never break the redirect by creating a new tl;dr I think the effort is trivial. Fork Test |
Alright, you know what, let's try this :) |
@ingria Do you foresee problems with this? Why are you 😕? |
Technically - no, not at all. I just didn't understand what the benefits of renaming would be. That's why I was a little 😕 Anyway, there are also some other places that might need to be edited:
|
Less confusion. Right now we use two names—"on-premise," "self-hosted"—for the same thing. May not be worth it. Need to stew on this some more ... 🤔 |
The more I think about it, the more I don't like either name— |
This name may better reflect how it's supposed to work, but it doesn't describe what is this project for. I mean, imagine you've just heard about some cool project called Gentry. And you'd like to know whether it's possible to use it on your own servers. How would you google it: "gentry self hosted" or "gentry single node"? In other words, "single-node" is ok for a repo name, but not ok for a product name. Just my opinion, of course. |
I agree with @ingria here, this was my main concern too. How about something like |
Returning to the original idea here, renaming to |
I ran this by the Backend TSC and nobody raised any red flags from a technical standpoint, experience with repo renames is that GitHub does a great job making it seamless. All clear from that standpoint! |
Looks like we 404'd that particular article (I remember doing this a month or so ago but I don't remember exactly what it was), I guess that was the only one. I just started a thread in the forums to see if anyone is paying attention there. Where I want to take that conversation is I actually want to deprecate the forum in favor of GitHub Issues. 🐭
I do find references to on-premise historically on the blog, looks like June, 2020 is the latest? Not all of the references |
I added a todo to this ticket. I'm going to let this forum meta post sit for a day or two, if it's 🦗 s then I intend to proceed with this ticket. If it's not then we'll talk first. :) |
I'm planning to rename the repo next week during the US Thanksgiving lull. |
Repo is done: https://github.com/getsentry/self-hosted. 💃 |
After reviewing the blog posts for mentions of "on-premise," I don't think we need to go back through and change those. There are 11 mentions but one is in reference to a different product. Of the 10 posts that talk about on-premise Sentry, three also refer to it as "open source" Sentry, which is definitely something we are moving away from—SaaS is open-source too, there's no feature difference between SaaS, single-tenant, and self-hosted. All that said, historically we did use "on-premise" and "open-source" to refer to the product now called "self-hosted Sentry," and I don't think we need to rewrite history. Being consistent in the future is enough.
|
I made PRs for the rest of the repos except for |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I got nervous when I noticed that the publish repo looks at the issue title, but we should be fine because the issue title comes from the repo slug. 👍 |
Wrong approach, need to revisit: getsentry/sentry#30556 (comment). |
(Inlining ...) The better way to do this is to:
The crux is that downstreams set the backend
|
Surfaced in review with Backend TSC:
|
Big config changes shipped to SaaS prod. A couple more bits to flip in the coming weeks/months and then removing backcompat "at some point." |
Flipped the bit on Rename: check! 💃 |
In the docs we're using "self-hosted" to name what we're doing here. For branding purposes I would like to standardize on that and stop referring to "onpremise."
(Short URL, fwiw: https://git.io/JSDlX)
Todo
sentry.io
—archived reposentry-release
—moribund repo, don't caresentry
isSelfHosted
insentry
(done in #30973)removeSENTRY_ONPREMISE
insingle-tenant
SENTRY_ONPREMISE
andisOnPremise
insentry
(kill backcompat) – do this, like, waaaaay laterblog—Rename onpremise to self-hosted #796 (comment)The text was updated successfully, but these errors were encountered: