Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename onpremise to self-hosted #796

Closed
42 tasks done
chadwhitacre opened this issue Jan 6, 2021 · 27 comments
Closed
42 tasks done

Rename onpremise to self-hosted #796

chadwhitacre opened this issue Jan 6, 2021 · 27 comments

Comments

@chadwhitacre
Copy link
Member

chadwhitacre commented Jan 6, 2021

In the docs we're using "self-hosted" to name what we're doing here. For branding purposes I would like to standardize on that and stop referring to "onpremise."

(Short URL, fwiw: https://git.io/JSDlX)

Todo

@BYK
Copy link
Member

BYK commented Jan 6, 2021

I'm not sure if the effort is worth the benefits.

@chadwhitacre
Copy link
Member Author

chadwhitacre commented Jan 6, 2021

GitHub handles renames gracefully. The one lingering question I've had is forks, but it seems from testing (not seeing docs) that there's no issue with a fork of a renamed repo. The fork keeps the old name, and its connection to the renamed parent. If anyone with a fork has the upstream set as a remote, GitHub redirection/aliasing ensures that they are unaffected—as long as we never break the redirect by creating a new onpremise repo.

tl;dr I think the effort is trivial.

Fork Test

Screen Shot 2021-01-06 at 4 54 56 PM

@BYK
Copy link
Member

BYK commented Jan 13, 2021

Alright, you know what, let's try this :)

@chadwhitacre
Copy link
Member Author

@ingria Do you foresee problems with this? Why are you 😕?

@ingria
Copy link

ingria commented Jan 14, 2021

Technically - no, not at all. I just didn't understand what the benefits of renaming would be. That's why I was a little 😕

Anyway, there are also some other places that might need to be edited:

@chadwhitacre
Copy link
Member Author

benefits

Less confusion. Right now we use two names—"on-premise," "self-hosted"—for the same thing. May not be worth it. Need to stew on this some more ... 🤔

@chadwhitacre
Copy link
Member Author

The more I think about it, the more I don't like either name—onpremise or self-hosted—for this repo. I think a better name would be single-node, because it better captures our intention here: to package up all of Sentry for deployment on a single node, in order to support a) proofs of concept for people evaluating SaaS, and b) small deployments for students, hobbyists, and small orgs. "Self-hosted" is broader as it really encompasses multi-node setups, too, which we don't officially support and never will (SaaS! SaaS!). Moreover, work that is relevant to self-hosters of any scale quite often (almost always?) impacts our other "primary" repos, e.g. #863 and #857 should really be against sentry, imo. We have a label in that repo to flag issues of particular (exclusive?) relevance to self-hosters.

@chadwhitacre chadwhitacre changed the title Rename onpremise to self-hosted Rename onpremise to single-node Feb 24, 2021
@ingria
Copy link

ingria commented Feb 24, 2021

This name may better reflect how it's supposed to work, but it doesn't describe what is this project for.

I mean, imagine you've just heard about some cool project called Gentry. And you'd like to know whether it's possible to use it on your own servers. How would you google it: "gentry self hosted" or "gentry single node"?

In other words, "single-node" is ok for a repo name, but not ok for a product name. Just my opinion, of course.

@BYK
Copy link
Member

BYK commented Mar 3, 2021

I agree with @ingria here, this was my main concern too. How about something like self-hosted-core or something as this setup can be expanded into a multi-node setup through Docker Swarm or something like https://kompose.io/. Also AFAIK https://github.com/sentry-kubernetes/charts/ is tracking this repo for updates.

@chadwhitacre chadwhitacre changed the title Rename onpremise to single-node Rename onpremise to self-hosted Nov 3, 2021
@chadwhitacre
Copy link
Member Author

Returning to the original idea here, renaming to self-hosted.

@chadwhitacre
Copy link
Member Author

chadwhitacre commented Nov 16, 2021

I ran this by the Backend TSC and nobody raised any red flags from a technical standpoint, experience with repo renames is that GitHub does a great job making it seamless. All clear from that standpoint!

@chadwhitacre
Copy link
Member Author

chadwhitacre commented Nov 16, 2021

Help articles (example)

Looks like we 404'd that particular article (I remember doing this a month or so ago but I don't remember exactly what it was), I guess that was the only one.

Community forums

I just started a thread in the forums to see if anyone is paying attention there. Where I want to take that conversation is I actually want to deprecate the forum in favor of GitHub Issues. 🐭

Blog articles (example)

I do find references to on-premise historically on the blog, looks like June, 2020 is the latest? Not all of the references

@chadwhitacre
Copy link
Member Author

I added a todo to this ticket. I'm going to let this forum meta post sit for a day or two, if it's 🦗 s then I intend to proceed with this ticket. If it's not then we'll talk first. :)

@chadwhitacre
Copy link
Member Author

I'm planning to rename the repo next week during the US Thanksgiving lull.

@chadwhitacre
Copy link
Member Author

Repo is done: https://github.com/getsentry/self-hosted. 💃

@chadwhitacre
Copy link
Member Author

After reviewing the blog posts for mentions of "on-premise," I don't think we need to go back through and change those. There are 11 mentions but one is in reference to a different product. Of the 10 posts that talk about on-premise Sentry, three also refer to it as "open source" Sentry, which is definitely something we are moving away from—SaaS is open-source too, there's no feature difference between SaaS, single-tenant, and self-hosted. All that said, historically we did use "on-premise" and "open-source" to refer to the product now called "self-hosted Sentry," and I don't think we need to rewrite history. Being consistent in the future is enough.

  1. https://blog.sentry.io/2020/06/22/self-hosted-sentry-switching-to-calver (1)
  2. https://blog.sentry.io/2020/01/07/self-hosted-sentry-10-is-ready-to-serve-get-it-while-its-hot (1)
  3. https://blog.sentry.io/2019/03/14/nextcloud-uses-sentry-to-build-federated-clouds (1) — this one refers to Nextcloud, not Sentry
  4. https://blog.sentry.io/2019/02/14/sentry-thrives-open-source-software-company (3 + "open source")
  5. https://blog.sentry.io/2016/07/05/releasing-sentry (4 + "open source")
  6. https://blog.sentry.io/2016/01/12/monitoring-the-monitor (8)
  7. https://blog.sentry.io/2015/12/29/sentry-js-sdk-release (1)
  8. https://blog.sentry.io/2015/10/08/sentry-8-is-here (8)
  9. https://blog.sentry.io/2015/09/29/sso-for-all (8)
  10. https://blog.sentry.io/2015/08/04/rethinking-sentrys-documentation (3 + "open source")
  11. https://blog.sentry.io/2015/06/30/driven-by-open-source (1)

@chadwhitacre
Copy link
Member Author

I made PRs for the rest of the repos except for sentry and getsentry. Those will take some more thought as what is at issue is a configuration change and we need to do handle that in a graceful way.

@renchap

This comment has been minimized.

@chadwhitacre

This comment has been minimized.

@chadwhitacre
Copy link
Member Author

Audit to make sure monthly CalVer release will work.

I got nervous when I noticed that the publish repo looks at the issue title, but we should be fine because the issue title comes from the repo slug. 👍

chadwhitacre added a commit to getsentry/snuba that referenced this issue Nov 29, 2021
@chadwhitacre
Copy link
Member Author

@ayozemr @fliespl et al. Now that #1169 has landed would someone be able to upgrade to the latest master and report back if you encounter any issues? I'd love to beta-test this a bit before the next monthly release. 🙏

@chadwhitacre
Copy link
Member Author

Wrong approach, need to revisit: getsentry/sentry#30556 (comment).

@chadwhitacre
Copy link
Member Author

(Inlining ...)

The better way to do this is to:

  1. Set SENTRY_SELF_HOSTED in the downstream apps (getsentry and single-tenant) as a no-op duplicate. It sits right next to SENTRY_ONPREMISE but nothing reads it.
  2. Modify the upstream (i.e., sentry, here) to use/read SENTRY_SELF_HOSTED on the backend (basically this here PR here).
  3. Remove SENTRY_ONPREMISE from the downstreams.
  4. Modify the upstream to set isSelfHosted as a no-op duplicate on the frontend.
  5. Modify the downstreams to read from isSelfHosted.
  6. Modify the upstream to read from isSelfHosted and remove isOnPremise.

The crux is that downstreams set the backend SENTRY_FOO but consume the frontend isFooBar, while upstreams consume the backend and set the frontend. The right approach looks like this:

backend  add    downstream
backend  add    upstream
backend  remove upstream
backend  remove downstream

frontend add    upstream
frontend add    downstream
frontend remove downstream
frontend remove upstream

@chadwhitacre
Copy link
Member Author

chadwhitacre commented Dec 14, 2021

Surfaced in review with Backend TSC:

  • don't remove ONPREMISE from sentry (upstream) until after removed from downstream
  • check on single-tenant flow, account for need to cut a release

@chadwhitacre
Copy link
Member Author

Big config changes shipped to SaaS prod. A couple more bits to flip in the coming weeks/months and then removing backcompat "at some point."

@chadwhitacre
Copy link
Member Author

Flipped the bit on getsentry, punting indefinitely on single-tenant. Gonna declare victory here.

Rename: check! 💃

@chadwhitacre chadwhitacre unpinned this issue Jan 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

4 participants