catch exception for general httpx networkerror

getsentry · Mar 25, 2024 · 82eed1e · 82eed1e
1 parent 2ccd1a5
commit 82eed1e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -77,10 +77,11 @@ jobs:
       - name: Setup dev environment
         run: |
           pip install -r requirements-dev.txt
+          echo "PY_COLORS=1" >> "$GITHUB_ENV"
           ### pytest-sentry configuration ###
           if [ "$GITHUB_REPOSITORY" = "getsentry/self-hosted" ]; then
             echo "PYTEST_SENTRY_DSN=$SELF_HOSTED_TESTING_DSN" >> $GITHUB_ENV
-            echo "PYTEST_SENTRY_TRACES_SAMPLE_RATE=0.0" >> $GITHUB_ENV
+            echo "PYTEST_SENTRY_TRACES_SAMPLE_RATE=0" >> $GITHUB_ENV
 
             # This records failures on master to sentry in order to detect flakey tests, as it's
             # expected that people have failing tests on their PRs

diff --git a/_integration-test/conftest.py b/_integration-test/conftest.py
@@ -19,7 +19,7 @@ def configure_self_hosted_environment(request):
     for i in range(TIMEOUT_SECONDS):
         try:
             response = httpx.get(SENTRY_TEST_HOST, follow_redirects=True)
-        except httpx.ConnectError:
+        except httpx.NetworkError:
             time.sleep(1)
         else:
             if response.status_code == 200: