Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Simplify check #47

Merged
merged 2 commits into from
Jan 21, 2025
Merged

chore: Simplify check #47

merged 2 commits into from
Jan 21, 2025

Conversation

loewenheim
Copy link
Contributor

No description provided.

@loewenheim loewenheim requested a review from a team January 21, 2025 09:00
@loewenheim loewenheim self-assigned this Jan 21, 2025
jjbayer
jjbayer approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the conflict.

@loewenheim loewenheim changed the title chore: Clippy lints chore: Simplify check Jan 21, 2025
@loewenheim
Copy link
Contributor Author

Welp, the lints were already fixed. But there's still this check that can be simplified.

@loewenheim loewenheim merged commit ff576f1 into master Jan 21, 2025
6 checks passed
@loewenheim loewenheim deleted the chore/clippy branch January 21, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

@jjbayer jjbayer jjbayer approved these changes

Assignees

@loewenheim loewenheim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loewenheim @Swatinem @jjbayer