test: Add tests for masking of sensitive data #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
approved these changes
Feb 1, 2024
| @@ -7236,7 +7236,7 @@ exports[`record integration tests mutations should work when blocked class is un | |||
| \\"attributes\\": { | |||
| \\"class\\": \\"rr-block\\", | |||
| \\"rr_width\\": \\"1904px\\", | |||
| \\"rr_height\\": \\"21px\\" | |||
| \\"rr_height\\": \\"21.5px\\" | |||
Comment on lines
+21
to
+35
| <label> | ||
| <input autocomplete="cc-number" value="initial" /> | ||
| </label> | ||
| <label> | ||
| <input autocomplete="cc-exp" value="initial" /> | ||
| </label> | ||
| <label> | ||
| <input autocomplete="cc-exp-month" value="initial" /> | ||
| </label> | ||
| <label> | ||
| <input autocomplete="cc-exp-year" value="initial" /> | ||
| </label> | ||
| <label> | ||
| <input autocomplete="cc-csc" value="initial" /> | ||
| </label> |
There was a problem hiding this comment.
billyvg
reviewed
Feb 1, 2024
I'll add some in the follow up PR! |
mydea
added a commit
that referenced
this pull request
Feb 1, 2024
This is on top of #165, actually fixing the behavior so that certain fields cannot be unmasked. This is a pretty straightforward fix, a bit "hacky" but should work well enough. Fixes getsentry/sentry-javascript#10258 --------- Co-authored-by: mydea <[email protected]>
billyvg
pushed a commit
that referenced
this pull request
Apr 26, 2024
This tests masking of initial & updated values for password & credit card fields. You can see that for now credit card data is not masked, which demonstrates the current behavior. In a future PR we can then verify that our fixed masking is working. ref getsentry/sentry-javascript#10258
billyvg
pushed a commit
that referenced
this pull request
Apr 26, 2024
This is on top of #165, actually fixing the behavior so that certain fields cannot be unmasked. This is a pretty straightforward fix, a bit "hacky" but should work well enough. Fixes getsentry/sentry-javascript#10258 --------- Co-authored-by: mydea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests masking of initial & updated values for password & credit card fields.
You can see that for now credit card data is not masked, which demonstrates the current behavior.
In a future PR we can then verify that our fixed masking is working.
ref getsentry/sentry-javascript#10258