-
Notifications
You must be signed in to change notification settings - Fork 103
feat(ourlog): Add vercel log drain endpoint #5212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
837b7d7
to
1dac424
Compare
3810607
to
ec8cfbf
Compare
771fc43
to
c95f053
Compare
c95f053
to
d25fc99
Compare
headers={"Content-Type": "application/json"}, | ||
) | ||
|
||
# Check that the items are properly processed via items_consumer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What else?
} | ||
|
||
if count == 0 { | ||
relay_log::debug!("Failed to parse any logs from vercel log drain payload"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does output when you get empty arrays, but this is unexpected from the log drain endpoint.
After implementing this I also realized that we could return the count
from expand
, and use that accordingly, we can make a similar refactor to the otlp integration.
Pull Request is not mergeable
resolves https://linear.app/getsentry/issue/LOGS-389/add-vercel-log-drain-endpoint-to-relay
Building on top of the vercel log transform added in #5209, this PR adds an endpoint for the vercel log drain.
This endpoint is featured flagged, you can see the options automator PR here: https://github.com/getsentry/sentry-options-automator/pull/5367