feat(on-demand): Add computed contexts #4239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports computed contexts, which are calculated in the same way as in Sentry (https://github.com/getsentry/sentry/blob/486bebce5331397094f2fe37a85dd78b938c7f55/src/sentry/interfaces/contexts.py#L177-L177).
The reason for this change is that metrics extraction works only on data materialized by Relay within the event payload. In practice, some customer queries in Discover might rely on computed fields on the Sentry side, making the on-demand spec generation ineffective, as Relay does not recognize these fields.
For example,
os:Somethingmatches an os tag generated by Sentry as a combination of"{os.name} {os.version}". To address this, we are now replicating this behavior in Relay as well.Closes: #4205