Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(project-config): Graduate more feature flags #4080

Merged
merged 3 commits into from
Sep 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,10 @@

**Internal:**

- Remove unused `cogs.enabled` configuration option. ([#4060](https://github.com/getsentry/relay/pull/4060))
- Add the dynamic sampling rate to standalone spans as a measurement so that it can be stored, queried, and used for extrapolation. ([#4063](https://github.com/getsentry/relay/pull/4063))
- Allowlist the SentryUptimeBot user-agent. ([#4068](https://github.com/getsentry/relay/pull/4068))

**Internal:**

- Remove unused `cogs.enabled` configuration option. ([#4060](https://github.com/getsentry/relay/pull/4060))
- Feature flags of graduated features are now hard-coded in Relay so they can be removed from Sentry. ([#4076](https://github.com/getsentry/relay/pull/4076), [#4080](https://github.com/getsentry/relay/pull/4080))

## 24.9.0

Expand Down
46 changes: 10 additions & 36 deletions relay-dynamic-config/src/feature.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@ use serde::{Deserialize, Serialize};

/// Feature flags of graduated features are no longer sent by sentry, but Relay needs to insert them
/// for outdated downstream Relays that may still rely on the feature flag.
pub const GRADUATED_FEATURE_FLAGS: &[Feature] = &[Feature::UserReportV2Ingest];
pub const GRADUATED_FEATURE_FLAGS: &[Feature] = &[
Feature::UserReportV2Ingest,
Feature::IngestUnsampledProfiles,
];

/// Features exposed by project config.
#[derive(Clone, Copy, Debug, Eq, PartialEq, PartialOrd, Ord, Hash, Serialize, Deserialize)]
Expand All @@ -30,13 +33,6 @@ pub enum Feature {
/// Serialized as `organizations:session-replay-video-disabled`.
#[serde(rename = "organizations:session-replay-video-disabled")]
SessionReplayVideoDisabled,
/// Enables new User Feedback ingest.
///
/// This feature has graduated and is hard-coded for external Relays.
///
/// Serialized as `organizations:user-feedback-ingest`.
#[serde(rename = "organizations:user-feedback-ingest")]
UserReportV2Ingest,
/// Enables device.class synthesis
///
/// Enables device.class tag synthesis on mobile events.
Expand All @@ -49,7 +45,6 @@ pub enum Feature {
/// Serialized as `organizations:custom-metrics`.
#[serde(rename = "organizations:custom-metrics")]
CustomMetrics,

/// Enable processing profiles.
///
/// Serialized as `organizations:profiling`.
Expand All @@ -65,19 +60,16 @@ pub enum Feature {
/// Serialized as `projects:relay-otel-endpoint`.
#[serde(rename = "projects:relay-otel-endpoint")]
OtelEndpoint,

/// Discard transactions in a spans-only world.
///
/// Serialized as `projects:discard-transaction`.
#[serde(rename = "projects:discard-transaction")]
DiscardTransaction,

/// Enable continuous profiling.
///
/// Serialized as `organizations:continuous-profiling`.
#[serde(rename = "organizations:continuous-profiling")]
ContinuousProfiling,

/// Enables metric extraction from spans for common modules.
///
/// Serialized as `projects:span-metrics-extraction`.
Expand All @@ -89,44 +81,26 @@ pub enum Feature {
/// Serialized as `projects:span-metrics-extraction-addons`.
#[serde(rename = "projects:span-metrics-extraction-addons")]
ExtractAddonsSpanMetricsFromEvent,

/// When enabled, spans will be extracted from a transaction.
///
/// Serialized as `organizations:indexed-spans-extraction`.
#[serde(rename = "organizations:indexed-spans-extraction")]
ExtractSpansFromEvent,

/// Enables description scrubbing for MongoDB spans (and consequently, their presence in the
/// Queries module inside Sentry).
///
/// Serialized as `organizations:performance-queries-mongodb-extraction`.
#[serde(rename = "organizations:performance-queries-mongodb-extraction")]
ScrubMongoDbDescriptions,

/// Deprecated, still forwarded for older downstream Relays.
#[doc(hidden)]
#[serde(rename = "organizations:transaction-name-mark-scrubbed-as-sanitized")]
Deprecated1,
/// Deprecated, still forwarded for older downstream Relays.
#[doc(hidden)]
#[serde(rename = "organizations:transaction-name-normalize")]
Deprecated2,
/// Deprecated, still forwarded for older downstream Relays.
#[doc(hidden)]
#[serde(rename = "projects:extract-standalone-spans")]
Deprecated4,
/// Deprecated, still forwarded for older downstream Relays.
#[doc(hidden)]
#[serde(rename = "projects:span-metrics-extraction-resource")]
Deprecated5,
/// Deprecated, still forwarded for older downstream Relays.
#[doc(hidden)]
#[serde(rename = "projects:span-metrics-extraction-all-modules")]
Deprecated6,
/// Deprecated, still forwarded for older downstream Relays.
/// This feature has graduated and is hard-coded for external Relays.
#[doc(hidden)]
#[serde(rename = "projects:profiling-ingest-unsampled-profiles")]
Deprecated7,
IngestUnsampledProfiles,
/// This feature has graduated and is hard-coded for external Relays.
#[doc(hidden)]
#[serde(rename = "organizations:user-feedback-ingest")]
UserReportV2Ingest,
/// Forward compatibility.
#[doc(hidden)]
#[serde(other)]
Expand Down
Loading