Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cli #7

Merged
merged 4 commits into from
Oct 4, 2024
Merged

feat: Add cli #7

merged 4 commits into from
Oct 4, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Oct 4, 2024

Adds a cli that can be used to add debug IDs to any directory of files.

We also run the CLI after build on our own dist directory so that our output files have debug IDs!

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add an engines to package.json if we have a CLI.

I created #8 to track publishing. We also should think about making this a monorepo and individually publishing stuff.

@timfish
Copy link
Collaborator Author

timfish commented Oct 4, 2024

We also should think about making this a monorepo and individually publishing stuff

I was hoping we could just keep a single package since there are no dependencies, there's not much code and the exports mean that the different features are quite isolated.

The only plus I can see from a monorepo is that we can have e2e tests that actually ref the package rather than a relative path, ie ../../dist/rollup.js.

@timfish
Copy link
Collaborator Author

timfish commented Oct 4, 2024

Adding engines causes the parcel tests to fail seemingly due to this so I'll add that in later!

@timfish timfish merged commit 2c898c0 into main Oct 4, 2024
5 checks passed
@timfish timfish deleted the feat/cli branch October 4, 2024 19:09
@AbhiPrasad
Copy link
Member

I was hoping we could just keep a single package since there are no dependencies, there's not much code and the exports mean that the different features are quite isolated.

For bundler plugins we should always emit separate packages because it makes peer deps resolution easier. It also means we can individually control min node versions.

Another advantage is that download analytics becomes much more valuable, we can track specific adoption way more easily (which is important because we are trying to make the case to upstream these).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants