-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add potato when reacting to message #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, will take some time for this to get in production though since we need to add the reaction_added
scope to the bot which means that the app will need to be re authorised.
Co-authored-by: Tobias Wilfert <[email protected]>
True. It would be cool if someone can test this locally to make sure this works as expected as I coded it without any feedback. |
@tobias-wilfert @vladanpaunovic I pushed some changes.
I personally do not like how HeyTaco implemented their reaction feature in terms of UX, so right now, we only award a potato to the creator of the message instead of giving out potato to all people mentioned in the message. This is ofc up for debate. I also added blaming people if they are selfish and give potato to themselves 🙈 The remaining changes are housekeeping and the addition of lodash, to be able to compare if two arrays are equal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work @cleptric and @vladanpaunovic
Closes #4
I couldn't find a way to test this. I am fairly confident that this works. 😄
So if anyone can test this before merging it would be a great help.