Unfurling Discord Message Links #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will increase total bundle size by 1.47kB (0.28%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
============================================
- Coverage 25.65% 24.80% -0.86%
- Complexity 311 315 +4
============================================
Files 74 77 +3
Lines 3297 3435 +138
============================================
+ Hits 846 852 +6
- Misses 2451 2583 +132 ☔ View full report in Codecov by Sentry. |
cleptric
approved these changes
Dec 13, 2024
src/Event/LinkSharedEvent.php
Outdated
| { | ||
| foreach ($this->links as $link) { | ||
| // if Discord link, unfurl and fetch the message and return it | ||
| if (str_starts_with($link['url'], 'https://discord.com/')) { |
There was a problem hiding this comment.
@HazAT As Slack only emits events for configured domains, do we need this check?
src/Event/LinkSharedEvent.php
Outdated
| foreach ($this->links as $link) { | ||
| // if Discord link, unfurl and fetch the message and return it | ||
| if (str_starts_with($link['url'], 'https://discord.com/')) { | ||
| $message = $this->fetchDiscordMessage($link['url']); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From:
To:
Todos: