Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

Commit

Permalink
Update span-data-conventions for HTTP.status_code (#940)
Browse files Browse the repository at this point in the history
* Update span-data-conventions for HTTP.status_code

Per https://github.com/getsentry/team-webplatform-meta/issues/65 we want to define where HTTP status codes should be stored in events (200, 404, 500, etc)

Reasoning for why it is a problem, is that SDKs generally should not set tags "for" users on events.

* Update src/docs/sdk/performance/span-data-conventions.mdx

Co-authored-by: Manoel Aranda Neto <[email protected]>

---------

Co-authored-by: Anton Pirker <[email protected]>
Co-authored-by: Manoel Aranda Neto <[email protected]>
  • Loading branch information
3 people authored May 23, 2023
1 parent 0578b14 commit 30b6683
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/docs/sdk/performance/span-data-conventions.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Below describes the conventions for the Span interface for the `data` field on t
| `http.query` | string | The Query string present in the URL. | `?foo=bar&bar=baz` |
| `http.fragment` | string | The Fragments present in the URL. | `#foo=bar` |
| `http.method` | string | The HTTP method used. | `GET` |
| `http.status_code` | string | The status HTTP response. | `404` |
| `http.response_content_length` | number | The encoded body size of the response. | `123` |
| `http.decoded_response_body_length` | number | The decoded body size of the response. | `456` |
| `http.response_transfer_size` | number | The transfer size of the response. | `789` |
Expand Down

1 comment on commit 30b6683

@vercel
Copy link

@vercel vercel bot commented on 30b6683 May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

develop – ./

develop.sentry.dev
develop-git-master.sentry.dev

Please sign in to comment.