ref: upgrade isort to work around poetry breakage #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile-sentry
changed the title
evanh
approved these changes
Jan 30, 2023
|
@evanh I can't seem to merge here -- is the repo set to require up-to-date branches? |
|
Yes it does. Should we remove that? |
|
that's what I'd recommend heh -- you can check the box that allows that dropdown to be there, but I find requiring it is a really bad experience (I shouldn't have to rebase every open PR because someone fixed a typo for example) |
|
OK well @lynnagara is the owner of this repo. I'll let her make the call. |
|
Disabled the rule, it's mergeable without updating now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python-poetry/poetry-core#542
Committed via https://github.com/asottile/all-repos