Configure self-hosted to test the specified image #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Validating in getsentry/sentry#42959. |
|
Here's a run ... |
|
I don't understand why it's not failing since |
|
Yeah I don't get it. I get an empty string for the value of |
chadwhitacre
force-pushed
the
cwlw/configure-for-test-image
branch
from
226e1ad
to
70d21b2
Compare
chadwhitacre
force-pushed
the
cwlw/configure-for-test-image
branch
from
e46eefd
to
a1aa707
Compare
|
Let's depend on the |
hubertdeng123
approved these changes
Jan 9, 2023
|
Looks good! 👍 |
This was referenced Jan 9, 2023
chadwhitacre
added a commit
to getsentry/sentry
that referenced
this pull request
Jan 9, 2023
This is a follow-up to #42953 now that the fix has been generalized in the action in getsentry/action-self-hosted-e2e-tests#3.
17 tasks
chadwhitacre
added a commit
to getsentry/relay
that referenced
this pull request
Jan 10, 2023
Picks up getsentry/action-self-hosted-e2e-tests#3. #skip-changelog
|
Quick post-mortem/retro on this w/ @ethanhs ... lesson learned for next time: move to PR/review workflow off the bat in the action vs. direct-to-main in action (and counting on review from the PR in the other repo). |
olksdr
pushed a commit
to getsentry/relay
that referenced
this pull request
Jan 11, 2023
Picks up getsentry/action-self-hosted-e2e-tests#3. #skip-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't testing the image passed in via
image_url.Generalization of the fast fix in getsentry/sentry#42953.