Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed error handling for passport api #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fatimaaurangzeb0640
Copy link
Contributor

@fatimaaurangzeb0640 fatimaaurangzeb0640 commented Sep 11, 2024

Description

Fixed error handling for passport api. The error response for passport api looks like this:

SafepayAuthenticationError: unauthorized, strategies/union: [strategies/jwt_client: missing jwt token, strategies/secret: could not fetch client, error: Resource with this identifier not found] at /Users/fatima/Code/test-app/node_modules/@sfpy/node-core/cjs/RequestSender.js:27:27 at process.processTicksAndRejections (node:internal/process/task_queues:95:5) { type: 'SafepayAuthenticationError', status: 401 }

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • UI change (Front-end UI update without breaking changes or business logic)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Description

  1. What is the current behavior? (You can also link to an open issue here)

  2. What is the new behavior (if this is a feature change)?

  3. Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

headers: {},
data: {
// @ts-ignore
message: error.message,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we want to print error.message? wouldn't that always just be fail? shouldn't it print the actual message inside the errors array?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants