Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Node.js, Gatsby, and package version #695

Closed
wants to merge 54 commits into from
Closed

Bump Node.js, Gatsby, and package version #695

wants to merge 54 commits into from

Conversation

lucydodo
Copy link
Member

@lucydodo lucydodo commented Apr 12, 2024

Caution

This PR contains BREAKING CHANGES.
I've tested it on a number of cases, but we should take the review with a grain of salt.

Caution

We should revert commit 470616b before merging.

Major changes

  1. Upgrade Node.js engine version (10 -> 20.x LTS): 8d387f9
  2. Upgrade Gatsby version (2 -> 5)
  3. Upgrade related dependency package versions
  4. Fix security vulnerabilities of concern due to outdated package versions.
  5. Configure ESLint and fix : c6bf558
  6. Make Docker work for the above changes: b0214f5

How to test this PR

I'm deploying through my AWS. You can test it at the following link: https://redash.lucydodo.com

I look forward to any comments and reviews. and also if you have any questions, feel free to ask.
Thank you. :)

@lucydodo lucydodo self-assigned this Apr 12, 2024
Copy link
Member Author

@lucydodo lucydodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A runtime error has been reported for the /help/user-guide/ subpath, I'm checking now. Fixed via 5db6a44

Copy link
Member Author

@lucydodo lucydodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was reported that an image was not output from `/help/user-guide/visualizations/pivot-table-visualizations/'.
Fixed via e642332

Copy link
Member Author

@lucydodo lucydodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An issue was reported where links would fail to render when served usign {% link %} syntax.
I'm working on a fix, but it's likely to take some time. :(
Fixed via 83477ab

@justinclift
Copy link
Member

justinclift commented Apr 13, 2024

Hmmm, I wonder if we should do something about this restyled CI check too. It was more annoying than useful in the setup repo (so it got removed), but it might actually serve a useful purpose (unsure).

@lucydodo
Copy link
Member Author

Yes, I am aware of this and I will have to address it, but for now I want to test the site to make sure it works first, otherwise the style change will cause a lot of changes that will be a bit difficult to debug. :)

@justinclift
Copy link
Member

Cool, makes sense. 😄

isdzulqor and others added 21 commits April 17, 2024 08:27
* Add link to redash-migrate documentation
* Add example of horizontal bar chart image and text that's helpful for
searchers.
* Add reference to horizontal box plots for text searchers
* Add information about using typescript and yarn instead of JS and npm
* Documents update from getredash/redash#5314
* Add detail about muting alerts
* Remove unecessary screenshot and update dynamic list to include last
twelve months
* document disabling public urls
* Document Google Login and static SAML auth
* Document blocked domains environment variable
* Document the python query runner and add images for mongo and chart_3
* Update databricks query runner documentation for V10
* Add information about Dashboard URLs (I updated the V10 release notes about this as well)
* Document new CSV query runner
* Bump minimum RAM requirement until we can figure out why it's elevated
* Add link to migration demo video
* Remove newsletter link.

* Small updates to make it more community & oss focused.
* docs: Prettify example JSON object
* docs/api: Add headings for Jobs & Query Results
* Remove contact page.
* References to hosted Redash cleanup.
* Remove hosted redash reference in search results.
* Restyled by prettier (#636)
* Update developer docker instructions for .env file secret keys
* Clarify google login behavior for visitors without existing accounts
* Update links to forum to point at github discussions.

* Restyled by prettier (#666)

Co-authored-by: Restyled.io <[email protected]>

---------

Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com>
Co-authored-by: Restyled.io <[email protected]>
* Remove links to tos/privacy policy.

* Restyled by prettier

---------

Co-authored-by: Restyled.io <[email protected]>
An alert template variable QUERY_RESULT_TABLE was introduced so
that query results can be easily rendered in a mustache template.

Restyle with prettier
lucydodo and others added 22 commits April 17, 2024 08:27
Co-authored-by: Deji <[email protected]>
Co-authored-by: SeongTae Jeong <[email protected]>
via 'yarn upgrade --latest --ignore-platform'
Warning: This commit should be reverted before merging upstream.
@lucydodo
Copy link
Member Author

I tried to change the branch of the head repo with the PR open due to a tangle of commits in the branch,
but it didn't work, so I was forced to open a new PR. I apologize for the hassle. New PR: #703

@justinclift
Copy link
Member

No worries at all. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.