-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure AD Oauth Login for Redash #5795
Conversation
Looking at test failures |
@susodapop Looks like all checks are passing. What do I need to do to get this reviewed? Let me know if you need anything or have any questions! |
Thanks for pinging. My target is to review within two weeks of applying the |
@susodapop Can you confirm if you are blocked on anything from me? Do I need to do anything to apply to the "Team Review"? I can also help this process by bringing a 2nd or 3rd set of eyes to supplement your review. Let me know if this would help |
Yes absolutely this would help. I appreciate your efforts to get this across the line 🙏 |
@georgewfisher thanks for your contribution! We've made quite a few changes after the switch to community-driven development, would you mind rebasing off of |
What type of PR is this?
Description
Enable Azure AD Oauth login for Redash. Enables a login "with work or school account" option to be configured for the Redash login page which allows the user to authenticate using their Azure/Microsoft work or school identity and generate an associated Redash account.
Implementation is based on Google Oauth code in Redash that already exists. Some consolidation between Google and Azure Oauth code might be possible, but due to need to separate UI, I felt it was cleaner to keep them separate. I have not added RBAC (role-based access control) role verification to this PR but could easily do so (I plan to do this in a future PR).
How is this tested?
Manual testing scope involved local and cloud deployment test setup, test domain configuration, test login, test user account creation, verify user account is functional.
Related Tickets & Documents
getredash/website#658
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Azure AD login using "Microsoft work or school" customer facing langugage:

Authentication settings UI under general settings. Shows up only if Azure authentication is enabled.
