Skip to content

Conversation

@rauchy
Copy link
Contributor

@rauchy rauchy commented Feb 8, 2020

We need to keep jobs for longer, as people can execute a query, close the machine, come back and it shouldn't fail.

Also, in case the job isn't found, we should return proper message instead of currently the server blowing up.

@arikfr
Copy link
Member Author

arikfr commented Feb 9, 2020

Please rebase with master, so we can rule out failures due to #4617.

@rauchy rauchy force-pushed the keep-adhoc-job-results-for-longer branch from 81c6052 to 678835c Compare February 9, 2020 09:42
@rauchy
Copy link
Contributor

rauchy commented Feb 9, 2020

Please rebase with master, so we can rule out failures due to #4617.

Why would #4617 make a difference here?

@arikfr
Copy link
Member Author

arikfr commented Feb 9, 2020

Because it prevents running tests.

Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rauchy rauchy merged commit 7edac9c into master Feb 9, 2020
@rauchy rauchy deleted the keep-adhoc-job-results-for-longer branch February 9, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants