Add: error bands support to graphs (all except pie) #1430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Nov 25, 2016
| @@ -224,6 +224,7 @@ function QueryResultService($resource, $timeout, $q) { | |||
| let seriesName; | |||
| let xValue = 0; | |||
| const yValues = {}; | |||
| let eValue = 0; | |||
There was a problem hiding this comment.
I just realized that we will always have an eValue... did you check how it affects queries that don't have a error column set?
There was a problem hiding this comment.
yes, they work just fine.
There was a problem hiding this comment.
if the error is 0 , plotly ignores it?
There was a problem hiding this comment.
@arikfr for some reason they do look fine even though with the errors = 0 they should look slightly different. I want to review this throughly on Monday, also I find very annoying that after I set an error/group by column I cannot clear it, so I want to add that feature as well.
|
closing as this must now go into master and there were some commits imported that weren't mine.. #1433 is the updated PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixing problem with picked up commits in #1404)