-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*): enable parameters of type file in Porter manifest #579
Conversation
0520331
to
c3dd75f
Compare
c3dd75f
to
60710d4
Compare
60710d4
to
628c12f
Compare
@vdice We are finally off of that one custom branch of cnab-go! 🎉 I think you are all set to rebase your cnab-go branch off of |
628c12f
to
25509ad
Compare
@carolynvs Oops, I rebased my cnab-go branch off of master as opposed to
Still have the two comments/suggestions above to revisit... |
master is fine, we just needed to not move backwards is all 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small thing to fix and then we are good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2ee1655
to
918bacd
Compare
(last force-pushed commits represent rebase off master) |
Enables Porter manifest parameters of type
file
. Ref #480TODO:
vendor
mods: PR changes tocnab-go
and update Gopkg w/ temp commit, etc.... or something else entirely (see Parameter with valid JSON Schema definition may fail validation cnabio/cnab-go#117)Note: validation broken pending #581