Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inflated missing menu #6530

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Inflated missing menu #6530

merged 2 commits into from
Nov 22, 2024

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Nov 22, 2024

Closes #6529

Why is this the best possible solution? Were any other approaches considered?

There is nothing to discuss here. I've just added missing menu inflation.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

We can just test adding projects to make sure that importing QR codes from files is available. Nothing else should change.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as ready for review November 22, 2024 21:42
@lognaturel lognaturel merged commit f0ce2a6 into getodk:master Nov 22, 2024
6 checks passed
@dbemke
Copy link

dbemke commented Nov 25, 2024

Tested with Success!

Verified on a device with Androids 10

Verified cases:

@WKobus
Copy link

WKobus commented Nov 25, 2024

Tested with Success!

Verified on device with Android 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration QR code image can no longer be imported when creating a new project
4 participants