Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support to configure sass compiler, sassc is way fast #940

Merged
merged 2 commits into from
Nov 28, 2013

Conversation

ermeaney
Copy link
Contributor

I am working on a new theme using Foundation 5 using the sass sources. Compiling with the Ruby implementation of sass is sort of slow, and I wanted to be able to use sasc which is implemented in C++ and is way faster.

This pull request adds a configuration option SASS_COMPILER which defaults to 'sass' but allows you to configure which compiler you want to use.

@Kwpolska
Copy link
Member

  1. add yourself to authors.txt
  2. make a note in changes.txt
  3. add [email protected] to your GitHub emails
  4. I’ll handle the shell= fix myself

@ralsina
Copy link
Member

ralsina commented Nov 28, 2013

Looks good to me! (after you fix what @Kwpolska said)

@Kwpolska
Copy link
Member

Also, this invalid email issue is prevalent. I should write a script that automates fetching the address (github is not helpful). For the record:

cd /tmp
git clone [email protected]:AUTHOR/nikola --branch xyz
cd nikola
git log
# copy-paste the address into the comment

@ermeaney
Copy link
Contributor Author

@Kwpolska
Please bear with me, pretty new to git and this is my first pull request. Is this something you need me to do?
I am making the changes you mentioned now, but if there is something else you need me to do I wan tto take care of that first.

Thanks,

@Kwpolska
Copy link
Member

No, disregard those commands. You won’t get anything out of them.

Looks well. Merging.

Kwpolska added a commit that referenced this pull request Nov 28, 2013
added support to configure sass compiler, sassc is way fast
@Kwpolska Kwpolska merged commit 7b96f2e into getnikola:master Nov 28, 2013
@ghost ghost assigned Kwpolska Nov 28, 2013
@Kwpolska
Copy link
Member

It looks like there are no alternative LESS compilers, therefore I decided not to support setting a LESS compiler. If there is one, we can easily add it later.

@ralsina
Copy link
Member

ralsina commented Nov 28, 2013

@Kwpolska
Copy link
Member

This thing actually depends on the official lessc compiler.

@ralsina
Copy link
Member

ralsina commented Nov 28, 2013

Yes but it produces different output.

Kwpolska added a commit that referenced this pull request Nov 28, 2013
Signed-off-by: Chris “Kwpolska” Warrick <[email protected]>
@Kwpolska
Copy link
Member

there, done.

@ermeaney ermeaney deleted the sassc_support branch November 29, 2013 10:57
Kwpolska added a commit that referenced this pull request Nov 30, 2013
Signed-off-by: Chris “Kwpolska” Warrick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants