Sass compiling #822
Merged
Sass compiling #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris “Kwpolska” Warrick <[email protected]>
Signed-off-by: Chris “Kwpolska” Warrick <[email protected]>
Signed-off-by: Chris “Kwpolska” Warrick <[email protected]>
|
There, it works, and it’s quite sane. Anyone sees any issues, has any objections, or such? |
|
Why not in the plugins repo? |
|
|
Conflicts: CHANGES.txt
|
In other words: either we have both here, or move both into the plugins repo. Because |
|
Ok, more to eject for version 7 I guess. |
|
Merging this, and creating issue #824 to track stuff to move. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can see one caveat: with two extensions, we can get conflicts on which Nikola should die. I’m not quite sure what’s the best way to implement that.
So, treat this as code review/RFC.