Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore TranslatableSetting. #1112

Merged
merged 17 commits into from
Mar 12, 2014
Merged

Restore TranslatableSetting. #1112

merged 17 commits into from
Mar 12, 2014

Conversation

Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Mar 9, 2014

Complete with a saner implementation. This requires some hardcore testing, though — it’s better not to pull this just yet (unless, of course, you feel like doing the testing on your own).

This fixes #851.

Testing Checklist

The demo site should build and have sensible output with:

  • one language
  • two languages, with the same values, via string input
  • two languages, with the same values, via dict input for the default language
  • two languages, with the same values, via dict input for the other language
  • two languages, with different values, via dict input
  • three languages, with the same values, via string input
  • three languages, with the same values, via dict input for the default language
  • three languages, with the same values, via dict input for one of the other languages
  • three languages, with different values for two of the languages
  • three languages, with different values for two of the languages, none of which is the default
  • three languages, with different values for all three languages

Failures & Tasklist

  • develop a new infrastructure for formatting CONTENT_FOOTER
  • the new CONTENT_FOOTER formatting infrastructure and langformat() need extensive testing

@Kwpolska Kwpolska modified the milestones: v6.5.0, v7.0.0 Mar 9, 2014
@Kwpolska Kwpolska assigned ralsina and unassigned ralsina Mar 9, 2014
@Kwpolska
Restore TranslatableSetting.
487f535 
This was introduced in #851 and #1057 (to 3414efc), fixed
in #1061 (to 22912c8) and removed in 6554c27 for backwards
compatibility reasons (it was hard to maintain the compatibility).
@Kwpolska
Render TranslatableSettings where required.
738bf7b 
Signed-off-by: Chris “Kwpolska” Warrick <[email protected]>
@Kwpolska
Changelog entry for TranslatableSetting
f6c186d 
Signed-off-by: Chris “Kwpolska” Warrick <[email protected]>
@Kwpolska
Make TranslatableSettings aware of their names.
00a7ccd 
Signed-off-by: Chris “Kwpolska” Warrick <[email protected]>
@Kwpolska
"Default" to the first language if there is no value for the default …
7a73812 
…language.

Signed-off-by: Chris “Kwpolska” Warrick <[email protected]>
@Kwpolska
Fix the tests; modify language assuming.
3bf09ca 
Signed-off-by: Chris “Kwpolska” Warrick <[email protected]>
@Kwpolska
Change the way CONTENT_FOOTER is formatted.
6828a9b 
Signed-off-by: Chris “Kwpolska” Warrick <[email protected]>
@Kwpolska
changelog message for CONTENT_FOOTER_FORMATS
b55837c 
Signed-off-by: Chris “Kwpolska” Warrick <[email protected]>
@Kwpolska
BLOG_AUTHOR should not be undefined.
7432517 
Signed-off-by: Chris “Kwpolska” Warrick <[email protected]>
@Kwpolska
do not default to the first provided values
edfd8f8 
Signed-off-by: Chris “Kwpolska” Warrick <[email protected]>
@Kwpolska
Make CONTENT_FOOTER_FORMATS work properly.
9488085 
Signed-off-by: Chris “Kwpolska” Warrick <[email protected]>
@Kwpolska
Use the TranslatableSetting framework for NAVIGATION_LINKS
0d6ad97 
Signed-off-by: Chris “Kwpolska” Warrick <[email protected]>
@Kwpolska
Force post.author() to befriend TranslatableSetting
abbb4cb 
Signed-off-by: Chris “Kwpolska” Warrick <[email protected]>
@Kwpolska
Update the translated_titles conf.py to be v6-compatible.
d7b62b5 
Signed-off-by: Chris “Kwpolska” Warrick <[email protected]>
@Kwpolska
Add a fake BLOG_AUTHOR field to RSS testing.
6a06125 
Signed-off-by: Chris “Kwpolska” Warrick <[email protected]>
@Kwpolska
flake8 is a bastard sometimes.
197e8ee
@Kwpolska
Copy link
Member Author

This is 100% done. Waiting for reviews. If none appear, pulling in 24 hours.

cc @ralsina, @Aeyoun perchance?

Kwpolska added a commit that referenced this pull request Mar 12, 2014
@Kwpolska
Merge pull request #1112 from getnikola/translatablesetting
3489861 
Restore TranslatableSetting.
@Kwpolska Kwpolska merged commit 3489861 into master Mar 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.

Make it possible to have per-language site data (BLOG_{TITLE,DESCRIPTION})
2 participants
@Kwpolska @ralsina