Put RSS on a diet #1107
Put RSS on a diet #1107
Conversation
da2x
commented
Mar 7, 2014
da2x
commented
- only include xmlns:dc (Dublin Core) if used
- remove use of xmlns:atom
- optionally strip HTML
- reduce generator footprint (tiny)
| @@ -746,28 +749,38 @@ def url_replacer(self, src, dst, lang=None): | |||
|
|
|||
| def generic_rss_renderer(self, lang, title, link, description, timeline, output_path, | |||
| rss_teasers, feed_length=10, feed_url=None): | |||
| rss_obj = rss.RSS2( | |||
There was a problem hiding this comment.
why here? (Where was it before?)
also, why above the docstring?
There was a problem hiding this comment.
It must exist here because line 97-98.
There was a problem hiding this comment.
I noticed after commenting, but the docstring is still in the wrong place.
|
Looks well to me. |
|
Or maybe not. Issues:
|
|
(I must admit to never having used galleries nor their feeds.) |
| language=lang | ||
| ) | ||
| rss_obj.self_url = make_url(permalink) | ||
| rss_obj.rss_attrs["xmlns:atom"] = "http://www.w3.org/2005/Atom" |
There was a problem hiding this comment.
I don't like removing this. It makes the feeds give warnings in the W3C validator, and having it breaks nothing.
|
On Mar 7, 2014 9:05 PM, "Daniel Aleksandersen" [email protected]
Don't worry — I never really used them in production either. Also, I'm not sure whether the RSS.py change I suggested will work on /Chris, on mobile. |
|
galleries/rss.xml is empty on master. I don’t really see why. |
