Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New plugin manager does not support symlinks #3741

Closed
Kwpolska opened this issue Jan 14, 2024 · 0 comments · Fixed by #3742
Closed

New plugin manager does not support symlinks #3741

Kwpolska opened this issue Jan 14, 2024 · 0 comments · Fixed by #3742
Assignees
@Kwpolska
Labels
bug
Milestone
v8.3.1

Comments

@Kwpolska
Copy link
Member

Environment

Python Version: 3.11

Nikola Version: 8.3.0

Operating System: openSUSE Tumbleweed

Description:

The new plugin manager does not detect plugins if the plugin folder is a symlink (e.g. ln -s ../nikola-plugins/v8/projectpages plugins/projectpages).

Apparently, pathlib.Path.rglob ignores symlinks. We’ll need a custom thing to scan directories that does not ignore symlinks.
@Kwpolska Kwpolska added the bug label Jan 14, 2024
@Kwpolska Kwpolska added this to the v8.3.1 milestone Jan 14, 2024
@Kwpolska Kwpolska self-assigned this Jan 14, 2024
Kwpolska added a commit that referenced this issue Jan 15, 2024
@Kwpolska
Fix #3741 — symlink support in new plugin manager
961abfb
@Kwpolska Kwpolska linked a pull request Jan 15, 2024 that will close this issue
Fix #3741 — symlink support in new plugin manager #3742
Merged
Kwpolska added a commit that referenced this issue Jan 16, 2024
@Kwpolska
Fix #3741 — symlink support in new plugin manager (#3742)
f260a7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kwpolska Kwpolska

Labels
bug
Projects
None yet
Milestone
v8.3.1
Development

Successfully merging a pull request may close this issue.

Fix #3741 — symlink support in new plugin manager getnikola/nikola
1 participant
@Kwpolska