Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nikola strips away query strings with URL_TYPE='full_path' #3448

Closed
radek-sprta opened this issue Aug 11, 2020 · 2 comments
Closed

Nikola strips away query strings with URL_TYPE='full_path' #3448

radek-sprta opened this issue Aug 11, 2020 · 2 comments
Assignees

Comments

@radek-sprta
Copy link

radek-sprta commented Aug 11, 2020

Environment

Python Version:3.8.2

Nikola Version:8.1.1

Operating System:Ubuntu 20.04.1 LTS

Description:

As title says, with URL_TYPE='full_path', Nikola strips away query strings from links. Is that intentional?

Example:

The relevant line from the template:
<script src="/assets/js/test.js?version={{ assets_version }}"></script>

  • Result with URL_TYPE='rel_path':
    <script src="assets/js/all.js?version=1597143702"></script>
  • Result with URL_TYPE='full_path':
    <script src=/assets/js/all.js></script>
  • Result with URL_TYPE='absolute':
    <script src="https://example.org/assets/js/all.js?version=1597143702"></script>
@Kwpolska
Copy link
Member

Fixed in #3449, please test.

@radek-sprta
Copy link
Author

radek-sprta commented Aug 12, 2020 via email

Kwpolska added a commit that referenced this issue Aug 18, 2020
Fix #3448 — fix query/fragments in URL_TYPE=full_path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants