Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(drone): force setup with node v10.15 #37

Merged
merged 1 commit into from
Jun 10, 2019
Merged

ci(drone): force setup with node v10.15 #37

merged 1 commit into from
Jun 10, 2019

Conversation

simontabor
Copy link
Contributor

@simontabor simontabor commented Jun 10, 2019

What did you implement:

Node v10.16 was recently released with [email protected] bundled with it.

[email protected] has a serious issue breaking our CI pipeline, so let's avoid it by downgrading to Node v10.15 which is bundled with [email protected]

How did you implement it:

Downgrading Node (and therefore npm) to the last working version. Should be a temporary measure until [email protected] is released.

How can we verify it:

Drone pipeline is now passing again.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / projects / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Copy link
Contributor

@gsingh1 gsingh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥑

@simontabor simontabor merged commit 8e46374 into master Jun 10, 2019
@simontabor simontabor deleted the fix/npm-bug branch June 10, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants