RDS: add OriginalSnapshotCreateTime to DB snapshots #8540
+38
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In contrast to `SnapshotCreateTime`, the `OriginalSnapshotCreateTime` does not change when the snapshot gets copied. Testing uses only 3 decimals for timestamp because the `iso_8601_datetime_with_milliseconds()` only provides 3. Skip some tests when in server mode, because `freeze_time` does not work there.
In those versions, `fromisoformat` only supports dates. But simply
`fromisoformat("2025-01-02")` also fails, because the timezone is
not correct when comparing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8540 +/- ##
=======================================
Coverage 92.63% 92.63%
=======================================
Files 1229 1229
Lines 106422 106423 +1
=======================================
+ Hits 98580 98582 +2
+ Misses 7842 7841 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bpandola
requested changes
Feb 1, 2025
| @@ -1912,6 +1921,7 @@ def copy_db_snapshot( | |||
| db_instance=source_snapshot.database, | |||
| db_snapshot_identifier=target_snapshot_identifier, | |||
| tags=tags, | |||
| original_created_at=source_snapshot.original_created_at, | |||
There was a problem hiding this comment.
Shouldn't this be orginal_created_at=source_snapshot.created_at?
| @@ -4,8 +4,10 @@ | |||
| import boto3 | |||
| import pytest | |||
| from botocore.exceptions import ClientError | |||
| from dateutil.tz import tzutc | |||
| from freezegun import freeze_time | |||
There was a problem hiding this comment.
Freezing time is a pain (doesn't work in server mode, etc.) and we should really only use it when absolutely necessary. Isn't it enough to assert that OrginalSnapshotCreateTIme == SnapshotCreateTime or SnapshotCreateTime > OriginalSnapshotCreateTime?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In contrast to
SnapshotCreateTime, theOriginalSnapshotCreateTimedoes not change when the snapshot gets copied.Testing uses only 3 decimals for timestamp because the
iso_8601_datetime_with_milliseconds()only provides 3. Skip some tests when in server mode, becausefreeze_timedoes not work there.