Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOTData: update_thing_shadow() now properly handles complex nested deltas #8342

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

bblommers
Copy link
Collaborator

@bblommers bblommers commented Nov 22, 2024

Fixes #8331

If there are other scenarios that I've missed, and the diff computation becomes even more complex, it might make sense to move away from jsondiff altogether, and add our own implementation. The whole point of jsondiff is to not have to deal with complexity like this. But for now, this will do.

@bblommers bblommers added this to the 5.0.22 milestone Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.58%. Comparing base (60328d5) to head (4ea7561).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8342   +/-   ##
=======================================
  Coverage   94.58%   94.58%           
=======================================
  Files        1159     1159           
  Lines      101063   101086   +23     
=======================================
+ Hits        95587    95611   +24     
+ Misses       5476     5475    -1     
Flag Coverage Δ
servertests 28.89% <10.71%> (-0.01%) ⬇️
unittests 94.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bblommers bblommers merged commit 73588d5 into getmoto:master Nov 23, 2024
53 checks passed
@bblommers bblommers deleted the iotdata-nested-diff branch November 23, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IoT Data Shadow Delta with complex datastructure exposes jsondiff symbol and raises TypeError
1 participant